Skip to content

Commit 3885d00

Browse files
authored
Make PSP deployment optional (#23)
* Make PSP configurable, disable it by default. BREAKING CHANGE: This disables the PodSecurityPolicy by default since PodSecurityPolicies have been removed in newer versions of Kubernetes. * fixup! Make PSP configurable, disable it by default.
1 parent cc8a918 commit 3885d00

File tree

5 files changed

+21
-4
lines changed

5 files changed

+21
-4
lines changed

charts/parca/Chart.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ type: application
2020
# This is the chart version. This version number should be incremented each time you make changes
2121
# to the chart and its templates, including the app version.
2222
# Versions are expected to follow Semantic Versioning (https://semver.org/)
23-
version: 2.3.1
23+
version: 3.0.0
2424

2525
# This is the version number of the application being deployed. This version number should be
2626
# incremented each time you make changes to the application. Versions are not expected to

charts/parca/README.md

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# parca
22

3-
![Version: 2.3.1](https://img.shields.io/badge/Version-2.3.1-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: v0.13.0](https://img.shields.io/badge/AppVersion-v0.13.0-informational?style=flat-square)
3+
![Version: 3.0.0](https://img.shields.io/badge/Version-3.0.0-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: v0.13.0](https://img.shields.io/badge/AppVersion-v0.13.0-informational?style=flat-square)
44

55
Open Source Infrastructure-wide continuous profiling
66

@@ -10,6 +10,12 @@ Open Source Infrastructure-wide continuous profiling
1010

1111
### Changes
1212

13+
#### 3.0.0
14+
15+
In chart version 3.0.0, the following has changed:
16+
17+
* The PodSecurityPolicy for the agents is now disabled by default as PSPs are removed with Kubernetes 1.25. Use `agent.enablePsp: true` if you want to keep it.
18+
1319
#### 2.3.1
1420
In the chart version 2.3.1, the following has changed:
1521
the _server.service.annotations_ is now available, so the parca server service manifest can have additional annotations.
@@ -47,6 +53,7 @@ helm repo add parca https://parca-dev.github.io/helm-charts
4753

4854
| Key | Type | Default | Description |
4955
|-----|------|---------|-------------|
56+
| agent.enablePsp | bool | `false` | If the PodSecurityPolicy should be enabled |
5057
| agent.enabled | bool | `true` | Allows disabling parca agent |
5158
| agent.extraArgs | list | `[]` | additional arguments to pass to the agent |
5259
| agent.extraEnv | list | `[]` | Additional container environment variables for agent |

charts/parca/README.md.gotmpl

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,12 @@
1010

1111
### Changes
1212

13+
#### 3.0.0
14+
15+
In chart version 3.0.0, the following has changed:
16+
17+
* The PodSecurityPolicy for the agents is now disabled by default as PSPs are removed with Kubernetes 1.25. Use `agent.enablePsp: true` if you want to keep it.
18+
1319
#### 2.3.1
1420
In the chart version 2.3.1, the following has changed:
1521
the _server.service.annotations_ is now available, so the parca server service manifest can have additional annotations.

charts/parca/templates/agent-podsecuritypolicy.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
{{- if .Values.agent.enabled -}}
1+
{{- if and .Values.agent.enabled .Values.agent.enablePsp -}}
22
apiVersion: policy/v1beta1
33
kind: PodSecurityPolicy
44
metadata:
@@ -36,4 +36,4 @@ spec:
3636
- downwardAPI
3737
- persistentVolumeClaim
3838
- hostPath
39-
{{- end }}
39+
{{- end }}

charts/parca/values.yaml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,10 @@ fullnameOverride: ""
88
agent:
99
# -- Allows disabling parca agent
1010
enabled: true
11+
12+
# -- If the PodSecurityPolicy should be enabled
13+
enablePsp: false
14+
1115
image:
1216
# -- Overrides the image repository
1317
repository: ghcr.io/parca-dev/parca-agent

0 commit comments

Comments
 (0)