fix: parachain informant (#9581)

Closes #9559.

The parachain informant was logging information for all parachains, not
just ours. This PR fixes that by filtering the events by parachain ID.

I tried adding a zombienet test for this but there isn't really a good
way to do it. So I ended up only testing manually with zombienet, by
creating a network of two parachains and adding some extra logging to
ensure that the events are now being filtered out correctly.

---------

Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Bastian Köcher <[email protected]>

Author: 3 people

cumulus/client/service/src/lib.rs

@@ -300,6 +300,7 @@ where
 		.spawn("cumulus-pov-recovery", None, pov_recovery.run());
 
 	let parachain_informant = parachain_informant::<Block, _>(
+		para_id,
 		relay_chain_interface.clone(),
 		client.clone(),
 		prometheus_registry.map(ParachainInformantMetrics::new).transpose()?,
@@ -605,6 +606,7 @@ where
 
 /// Task for logging candidate events and some related metrics.
 async fn parachain_informant<Block: BlockT, Client>(
+	para_id: ParaId,
 	relay_chain_interface: impl RelayChainInterface + Clone,
 	client: Arc<Client>,
 	metrics: Option<ParachainInformantMetrics>,
@@ -632,7 +634,10 @@ async fn parachain_informant<Block: BlockT, Client>(
 		let mut timed_out_candidates = Vec::new();
 		for event in candidate_events {
 			match event {
-				CandidateEvent::CandidateBacked(_, head, _, _) => {
+				CandidateEvent::CandidateBacked(receipt, head, _, _) => {
+					if receipt.descriptor.para_id() != para_id {
+						continue;
+					}
 					let backed_block = match Block::Header::decode(&mut &head.0[..]) {
 						Ok(header) => header,
 						Err(e) => {
@@ -652,7 +657,10 @@ async fn parachain_informant<Block: BlockT, Client>(
 					last_backed_block_time = Some(backed_block_time);
 					backed_candidates.push(backed_block);
 				},
-				CandidateEvent::CandidateIncluded(_, head, _, _) => {
+				CandidateEvent::CandidateIncluded(receipt, head, _, _) => {
+					if receipt.descriptor.para_id() != para_id {
+						continue;
+					}
 					let included_block = match Block::Header::decode(&mut &head.0[..]) {
 						Ok(header) => header,
 						Err(e) => {
@@ -670,7 +678,10 @@ async fn parachain_informant<Block: BlockT, Client>(
 					}
 					included_candidates.push(included_block);
 				},
-				CandidateEvent::CandidateTimedOut(_, head, _) => {
+				CandidateEvent::CandidateTimedOut(receipt, head, _) => {
+					if receipt.descriptor.para_id() != para_id {
+						continue;
+					}
 					let timed_out_block = match Block::Header::decode(&mut &head.0[..]) {
 						Ok(header) => header,
 						Err(e) => {

prdoc/pr_9581.prdoc

@@ -0,0 +1,8 @@
+title: 'fix: parachain informant'
+doc:
+- audience: Node Operator
+  description: |-
+    The parachain informant was logging information for all parachains, not just ours. This PR fixes that by filtering the events by parachain ID.
+crates:
+- name: cumulus-client-service
+  bump: patch