zombienet test fails after #7035

[pepoviola]

This 3 test start failing after merging #7035, all with timeout.

examples:

https://github.com/paritytech/polkadot-sdk/actions/runs/23751185563/job/69195857487
https://github.com/paritytech/polkadot-sdk/actions/runs/23751185563/job/69195858305
https://github.com/paritytech/polkadot-sdk/actions/runs/23740325701/job/69157291977

cc: @gui1117

[gui1117]

I tried to reproduce the test runtime_upgrade cumulus/zombienet/zombienet-sdk/tests/zombie_ci/runtime_upgrade.rs it succeeded.
Could it be flacky? I don't see any nondeterministic change in the PR. The extrinsic validation and execution shouldn't be changed, but if it is inadvertently changed then it should be always failing. So maybe the PR is not at fault.

I ran the test 3 times without any issue.

[pepoviola]

Hey @gui1117, thanks for checking this. I also tested locally and pass but CI is constantly failing after we merge that pr.
I used zombie-cli to reproduce the test with the same artifacts that we use in CI and there the issue is reproducible

For example

zombie-cli reproduce polkadot-sdk 23764055153 -p cumulus -- zombie_ci::runtime_upgrade::runtime_upgrade

I will try to investigate more about this fails.
Thx!

[pepoviola]

small update: reverting the pr also make those 3 test to pass again

https://github.com/paritytech/polkadot-sdk/actions/runs/23789153539/job/69325357844?pr=11571
https://github.com/paritytech/polkadot-sdk/actions/runs/23789153539/job/69325358454?pr=11571
https://github.com/paritytech/polkadot-sdk/actions/runs/23789153539/job/69325358516?pr=11571

[pepoviola]

small update: I add more debug logs and looks like the digest item RuntimeEnvironmentUpdated is never emitted.

https://github.com/paritytech/polkadot-sdk/actions/runs/23848343061/job/69535748980?pr=11593

[pepoviola]

Reproduced from CI artifacts, shows the tx error

[bkchr]

Reproduced from CI artifacts, shows the tx error

This just means that the code is too big. Probably the changes of @gui1117 pushed the generated code over the 3MiB boundary. Try building locally with debug asserts enabled for the wasm files, this probably is the difference between CI and local testing. Or a different rustc.

[eskimor]

Yep, confirmed. I already got CI green by enabling compression. Fix: #11641