UncheckedExtrinsic: Ensure that encoding leads to same bytes an ext was decoded from #10390
+253
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…as decoded from This pull request ensures that when decoding an `UncheckedExtrinsic` from a certain byte string, it also encodes to the same byte string. This is achieved by keeping the original bytes used to decode the `call` around and then directly encode these.
bkchr
added
the
T17-primitives
Member
Author
|
/cmd prdoc --bump major --audience runtime_dev |
…-audience runtime_dev'
bkchr
added
the
A4-backport-stable2512
serban300
approved these changes
Nov 25, 2025
substrate/primitives/runtime/src/generic/unchecked_extrinsic.rs
Outdated
Show resolved
Hide resolved
bkchr
commented
Nov 25, 2025
substrate/primitives/runtime/src/generic/unchecked_extrinsic.rs
Outdated
Show resolved
Hide resolved
|
All GitHub workflows were cancelled due to failure one of the required jobs. |
Member
Author
|
/cmd fmt |
ggwpez
reviewed
Nov 25, 2025
substrate/primitives/runtime/src/generic/unchecked_extrinsic.rs
Outdated
Show resolved
Hide resolved
Co-authored-by: Oliver Tale-Yazdi <[email protected]>
ggwpez
approved these changes
Nov 25, 2025
| } | ||
|
|
||
| /// Something which holds the actual call and maybe its encoded form. | ||
| pub struct CallAndMaybeEncoded<T> { |
Member
There was a problem hiding this comment.
Just as comment: We have a DoubleEncoded type that does this, but it in the XCM crate... it is also the other way around by always carrying the encoded version and only sometimes the decoded one.
| } | ||
|
|
||
| impl<T> From<T> for CallAndMaybeEncoded<T> { | ||
| fn from(value: T) -> Self { |
Member
There was a problem hiding this comment.
This is to make it a bit backwards compatible since any Call type can be converted to a CallAndMaybeEncoded?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request ensures that when decoding an
UncheckedExtrinsicfrom a certain byte string, it also encodes to the same byte string. This is achieved by keeping the original bytes used to decode thecallaround and then directly encode these.