feat: improve error handling in club and census services with detailed messages

Author: Windowsfreak

src/api/api_test.go

@@ -16,11 +16,11 @@ func TestDetectLanguage(t *testing.T) {
 		expected       string
 	}{
 		{
-			name:           "User preference takes precedence",
+			name:           "Header takes precedence over user preference",
 			userLanguage:   "fr",
 			headerLanguage: "es",
 			acceptLanguage: "de",
-			expected:       "fr",
+			expected:       "es",
 		},
 		{
 			name:           "X-Language header used if no user preference",

src/endpoints/clubs/club.go

@@ -30,7 +30,7 @@ type CreateClubRequest struct {
 func (h *ClubHandler) Create(w http.ResponseWriter, r *http.Request, _ httprouter.Params) {
 	user, err := api.GetUserFromContext(r)
 	if err != nil {
-		api.Error(w, r, err, http.StatusUnauthorized)
+		api.Error(w, r, t.Errorf("failed to get user from context: %w", err), http.StatusUnauthorized)
 		return
 	}
 
@@ -56,7 +56,7 @@ func (h *ClubHandler) Create(w http.ResponseWriter, r *http.Request, _ httproute
 
 	err = h.Service.CreateClub(r.Context(), clubEntity, user.Key)
 	if err != nil {
-		api.Error(w, r, err, http.StatusBadRequest)
+		api.Error(w, r, t.Errorf("could not create club: %w", err), http.StatusBadRequest)
 		return
 	}
 
@@ -66,14 +66,14 @@ func (h *ClubHandler) Create(w http.ResponseWriter, r *http.Request, _ httproute
 func (h *ClubHandler) Get(w http.ResponseWriter, r *http.Request, ps httprouter.Params) {
 	user, err := api.GetUserFromContext(r)
 	if err != nil {
-		api.Error(w, r, err, http.StatusUnauthorized)
+		api.Error(w, r, t.Errorf("failed to get user from context: %w", err), http.StatusUnauthorized)
 		return
 	}
 
 	key := ps.ByName("key")
 	club, err := h.Service.GetClub(r.Context(), key, user)
 	if err != nil {
-		api.Error(w, r, err, http.StatusForbidden)
+		api.Error(w, r, t.Errorf("failed to get club: %w", err), http.StatusForbidden)
 		return
 	}
 
@@ -83,7 +83,7 @@ func (h *ClubHandler) Get(w http.ResponseWriter, r *http.Request, ps httprouter.
 func (h *ClubHandler) Update(w http.ResponseWriter, r *http.Request, ps httprouter.Params) {
 	user, err := api.GetUserFromContext(r)
 	if err != nil {
-		api.Error(w, r, err, http.StatusUnauthorized)
+		api.Error(w, r, t.Errorf("failed to get user from context: %w", err), http.StatusUnauthorized)
 		return
 	}
 
@@ -102,7 +102,7 @@ func (h *ClubHandler) Update(w http.ResponseWriter, r *http.Request, ps httprout
 
 	err = h.Service.UpdateClub(r.Context(), key, updates, user)
 	if err != nil {
-		api.Error(w, r, err, http.StatusBadRequest)
+		api.Error(w, r, t.Errorf("could not update club: %w", err), http.StatusBadRequest)
 		return
 	}
 
@@ -113,14 +113,14 @@ func (h *ClubHandler) Update(w http.ResponseWriter, r *http.Request, ps httprout
 func (h *ClubHandler) Delete(w http.ResponseWriter, r *http.Request, ps httprouter.Params) {
 	user, err := api.GetUserFromContext(r)
 	if err != nil {
-		api.Error(w, r, err, http.StatusUnauthorized)
+		api.Error(w, r, t.Errorf("failed to get user from context: %w", err), http.StatusUnauthorized)
 		return
 	}
 
 	key := ps.ByName("key")
 	err = h.Service.DeleteClub(r.Context(), key, user)
 	if err != nil {
-		api.Error(w, r, err, http.StatusBadRequest)
+		api.Error(w, r, t.Errorf("could not delete club: %w", err), http.StatusBadRequest)
 		return
 	}
 
@@ -164,7 +164,7 @@ func FilteredResponse(clubEntity *entities.Club) *entities.Club {
 func (h *ClubHandler) AddOwner(w http.ResponseWriter, r *http.Request, ps httprouter.Params) {
 	user, err := api.GetUserFromContext(r)
 	if err != nil {
-		api.Error(w, r, err, http.StatusUnauthorized)
+		api.Error(w, r, t.Errorf("failed to get user from context: %w", err), http.StatusUnauthorized)
 		return
 	}
 
@@ -184,7 +184,7 @@ func (h *ClubHandler) AddOwner(w http.ResponseWriter, r *http.Request, ps httpro
 
 	err = h.Service.AddOwner(r.Context(), key, req.Email, user)
 	if err != nil {
-		api.Error(w, r, err, http.StatusBadRequest)
+		api.Error(w, r, t.Errorf("could not add owner: %w", err), http.StatusBadRequest)
 		return
 	}
 	// Return updated club
@@ -195,7 +195,7 @@ func (h *ClubHandler) AddOwner(w http.ResponseWriter, r *http.Request, ps httpro
 func (h *ClubHandler) RemoveOwner(w http.ResponseWriter, r *http.Request, ps httprouter.Params) {
 	user, err := api.GetUserFromContext(r)
 	if err != nil {
-		api.Error(w, r, err, http.StatusUnauthorized)
+		api.Error(w, r, t.Errorf("failed to get user from context: %w", err), http.StatusUnauthorized)
 		return
 	}
 
@@ -204,7 +204,7 @@ func (h *ClubHandler) RemoveOwner(w http.ResponseWriter, r *http.Request, ps htt
 
 	err = h.Service.RemoveOwner(r.Context(), key, targetUserKey, user)
 	if err != nil {
-		api.Error(w, r, err, http.StatusBadRequest)
+		api.Error(w, r, t.Errorf("could not remove user from list of owners: %w", err), http.StatusBadRequest)
 		return
 	}
 	// Return updated club

src/repository/graph/club.go

@@ -22,7 +22,7 @@ func (db *Db) CreateClub(ctx context.Context, club *entities.Club, userKey strin
 	// Create the club document
 	err := db.Clubs.Create(club, ctx)
 	if err != nil {
-		return err
+		return t.Errorf("could not create club document: %w", err)
 	}
 
 	// Create the 'authorizes' edge

src/repository/t/t.go

@@ -95,6 +95,13 @@ func LoadLanguages(config *dpv.Config) error {
 	}
 
 	for _, lang := range config.Settings.SupportedLanguages {
+		// English uses the raw keys as readable fallbacks and does not require a
+		// translation file. Skipping prevents noisy warnings about a missing
+		// strings_en.ini while still allowing "en" as a valid language choice.
+		if lang == "en" {
+			continue
+		}
+
 		path := config.Path + "strings_" + lang + ".ini"
 		m, err := loadFile(path)
 		if err != nil {

src/service/census/census.go

@@ -27,7 +27,7 @@ func NewService(db *graph.Db) *Service {
 func (s *Service) Get(ctx context.Context, clubKey string, year int, user *entities.User) (*entities.Census, error) {
 	authorized, err := s.IsAuthorized(ctx, user, clubKey)
 	if err != nil {
-		return nil, err
+		return nil, t.Errorf("authorization check failed while getting census: %w", err)
 	}
 	if !authorized {
 		return nil, t.Errorf("unauthorized: you are not a board member or admin")
@@ -38,7 +38,7 @@ func (s *Service) Get(ctx context.Context, clubKey string, year int, user *entit
 func (s *Service) Upsert(ctx context.Context, clubKey string, censusData *entities.Census, user *entities.User) error {
 	authorized, err := s.IsAuthorized(ctx, user, clubKey)
 	if err != nil {
-		return err
+		return t.Errorf("authorization check failed while upserting census: %w", err)
 	}
 	if !authorized {
 		return t.Errorf("unauthorized: you are not a board member or admin")
@@ -53,7 +53,7 @@ func (s *Service) IsAuthorized(ctx context.Context, user *entities.User, clubKey
 	}
 	administered, err := s.Db.GetAdministeredClubs(ctx, user.Key)
 	if err != nil {
-		return false, err
+		return false, t.Errorf("failed to load administered clubs for census authorization: %w", err)
 	}
 	for _, c := range administered {
 		if c.GetKey() == clubKey {

src/service/club/club.go

@@ -43,7 +43,7 @@ func (s *Service) IsAuthorized(ctx context.Context, user *entities.User, clubKey
 	}
 	administered, err := s.DB.GetAdministeredClubs(ctx, user.Key)
 	if err != nil {
-		return false, err
+		return false, t.Errorf("failed to load administered clubs for authorization: %w", err)
 	}
 	for _, c := range administered {
 		if c.GetKey() == clubKey {
@@ -57,7 +57,7 @@ func (s *Service) IsAuthorized(ctx context.Context, user *entities.User, clubKey
 func (s *Service) GetClub(ctx context.Context, key string, user *entities.User) (*entities.Club, error) {
 	authorized, err := s.IsAuthorized(ctx, user, key)
 	if err != nil {
-		return nil, err
+		return nil, t.Errorf("authorization check failed while getting club: %w", err)
 	}
 	if !authorized {
 		return nil, t.Errorf("unauthorized: you are not a board member or admin")
@@ -75,15 +75,15 @@ func (s *Service) ListClubs(ctx context.Context, userKey string) ([]entities.Clu
 func (s *Service) UpdateClub(ctx context.Context, key string, updates map[string]interface{}, user *entities.User) error {
 	authorized, err := s.IsAuthorized(ctx, user, key)
 	if err != nil {
-		return err
+		return t.Errorf("authorization check failed while updating club: %w", err)
 	}
 	if !authorized {
 		return t.Errorf("unauthorized: you cannot update this club")
 	}
 
 	club, err := s.DB.GetClubByKey(ctx, key)
 	if err != nil {
-		return err
+		return t.Errorf("failed to load club for update: %w", err)
 	}
 
 	// Apply updates
@@ -110,32 +110,38 @@ func (s *Service) UpdateClub(ctx context.Context, key string, updates map[string
 		club.Membership.Address = addr
 	}
 
-	return s.DB.UpdateClub(ctx, club)
+	if err := s.DB.UpdateClub(ctx, club); err != nil {
+		return t.Errorf("failed to update club: %w", err)
+	}
+	return nil
 }
 
 // DeleteClub deletes a club if the user is authorized.
 func (s *Service) DeleteClub(ctx context.Context, key string, user *entities.User) error {
 	authorized, err := s.IsAuthorized(ctx, user, key)
 	if err != nil {
-		return err
+		return t.Errorf("authorization check failed while deleting club: %w", err)
 	}
 	if !authorized {
 		return t.Errorf("unauthorized: you cannot delete this club")
 	}
 
 	club, err := s.DB.GetClubByKey(ctx, key)
 	if err != nil {
-		return err
+		return t.Errorf("failed to load club for deletion: %w", err)
 	}
 
-	return s.DB.DeleteClub(ctx, club)
+	if err := s.DB.DeleteClub(ctx, club); err != nil {
+		return t.Errorf("failed to delete club: %w", err)
+	}
+	return nil
 }
 
 // AddOwner adds a user as a club owner by email.
 func (s *Service) AddOwner(ctx context.Context, clubKey, email string, actor *entities.User) error {
 	authorized, err := s.IsAuthorized(ctx, actor, clubKey)
 	if err != nil {
-		return err
+		return t.Errorf("authorization check failed while adding owner: %w", err)
 	}
 	if !authorized {
 		return t.Errorf("unauthorized: you cannot manage owners for this club")
@@ -157,7 +163,7 @@ func (s *Service) AddOwner(ctx context.Context, clubKey, email string, actor *en
 func (s *Service) RemoveOwner(ctx context.Context, clubKey, targetUserKey string, actor *entities.User) error {
 	authorized, err := s.IsAuthorized(ctx, actor, clubKey)
 	if err != nil {
-		return err
+		return t.Errorf("authorization check failed while removing owner: %w", err)
 	}
 	if !authorized {
 		return t.Errorf("unauthorized: you cannot manage owners for this club")
@@ -171,7 +177,7 @@ func (s *Service) RemoveOwner(ctx context.Context, clubKey, targetUserKey string
 	// Rule: Cannot remove the last remaining owner
 	count, err := s.DB.CountVorstand(ctx, clubKey)
 	if err != nil {
-		return err
+		return t.Errorf("failed to count current owners: %w", err)
 	}
 	if count <= 1 {
 		// Verify if the target IS the one (should be if count is 1 and they exist)

src/service/club/membership.go

@@ -10,7 +10,7 @@ import (
 func (s *Service) Apply(ctx context.Context, key string, user *entities.User) error {
 	club, err := s.GetClub(ctx, key, user)
 	if err != nil {
-		return err
+		return t.Errorf("failed to load club for membership application: %w", err)
 	}
 
 	m := club.GetMembership()
@@ -19,14 +19,17 @@ func (s *Service) Apply(ctx context.Context, key string, user *entities.User) er
 	}
 
 	m.Status = "requested"
-	return s.DB.UpdateClub(ctx, club)
+	if err := s.DB.UpdateClub(ctx, club); err != nil {
+		return t.Errorf("failed to update club for membership application: %w", err)
+	}
+	return nil
 }
 
 // Approve marks a club's membership as approved.
 func (s *Service) Approve(ctx context.Context, key string) error {
 	club, err := s.DB.GetClubByKey(ctx, key)
 	if err != nil {
-		return err
+		return t.Errorf("failed to load club for approval: %w", err)
 	}
 
 	m := club.GetMembership()
@@ -35,14 +38,17 @@ func (s *Service) Approve(ctx context.Context, key string) error {
 	}
 
 	m.Status = "active"
-	return s.DB.UpdateClub(ctx, club)
+	if err := s.DB.UpdateClub(ctx, club); err != nil {
+		return t.Errorf("failed to update club for membership approval: %w", err)
+	}
+	return nil
 }
 
 // Deny marks a club's membership as denied.
 func (s *Service) Deny(ctx context.Context, key string) error {
 	club, err := s.DB.GetClubByKey(ctx, key)
 	if err != nil {
-		return err
+		return t.Errorf("failed to load club for denial: %w", err)
 	}
 
 	m := club.GetMembership()
@@ -51,14 +57,17 @@ func (s *Service) Deny(ctx context.Context, key string) error {
 	}
 
 	m.Status = "denied"
-	return s.DB.UpdateClub(ctx, club)
+	if err := s.DB.UpdateClub(ctx, club); err != nil {
+		return t.Errorf("failed to update club for membership denial: %w", err)
+	}
+	return nil
 }
 
 // Cancel marks a club's membership as cancelled or none.
 func (s *Service) Cancel(ctx context.Context, key string, user *entities.User) error {
 	club, err := s.GetClub(ctx, key, user)
 	if err != nil {
-		return err
+		return t.Errorf("failed to load club for membership cancellation: %w", err)
 	}
 
 	m := club.GetMembership()
@@ -68,5 +77,8 @@ func (s *Service) Cancel(ctx context.Context, key string, user *entities.User) e
 		m.Status = "inactive"
 	}
 
-	return s.DB.UpdateClub(ctx, club)
+	if err := s.DB.UpdateClub(ctx, club); err != nil {
+		return t.Errorf("failed to update club for membership cancellation: %w", err)
+	}
+	return nil
 }