Make NodeMap Thread-safe
#487
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR - adds `NodeId` to `StaticType`. - makes `AutoNodeIdGenerator` thread-safe - adds `PartiqlShapeBuilder` and moves some `PartiqlShape` APIs to it; this is to be able to generate unique `NodeId`s for a `PartiqlShape` that includes static types that themselves can include other static types. - adds a static thread safe `shape_builder` function that provides a convenient way for using `PartiqlShapeBuilder` for creating new shapes. - prepends existing type macros with `type` such as `type_int!` to make macro names more friendly. - removes `const` PartiQL types under `partiql-types` in favor of `PartiqlShapeBuilder`.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #487 +/- ##
==========================================
- Coverage 80.98% 80.95% -0.03%
==========================================
Files 69 69
Lines 18796 18822 +26
Branches 18796 18822 +26
==========================================
+ Hits 15221 15237 +16
- Misses 3131 3141 +10
Partials 444 444 ☔ View full report in Codecov by Sentry. |
Conformance comparison report
Number passing in both: 5731 Number failing in both: 612 Number passing in Base (7203852) but now fail: 0 Number failing in Base (7203852) but now pass: 0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Makes the
NodeMapthread-safe; this is a per-requisite for using the structure in thePartiQLShapeBuilder. It usesDashMapandVecunder the hood. It uses theVecfor preserving the ordering as the previous implementation was usingIndexMap.IndexMapdoes not seem to be thread-safe.The PR also makes necessary changes to preserve the behavior of the current
NodeMapdependencies.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.