-
-
Notifications
You must be signed in to change notification settings - Fork 6
Open
Description
Hi @patrick-kidger. If you're interested, I'd be happy to contribute
- A more comprehensive test suite, e.g. copy over https://github.com/GalacticDynamics/quaxed/blob/main/tests/test_lax/test_myarray.py & https://github.com/GalacticDynamics/quaxed/blob/main/tests/test_numpy/test_myarray.py which goes through every function. It caught BUG: in
Value.default#57 and Problem in_Quaxify.__call__#58, etc. - A benchmark suite, e.g. https://github.com/GalacticDynamics/unxt/runs/40852395818 to catch performance regressions. I'll probably basically copy over https://github.com/GalacticDynamics/unxt/blob/4c5c3d22a32047ccb5e86d1ad7b71a8ed0c88cf1/tests%2Fbenchmark%2Ftest_quaxed.py, but modify it for a
MyArray, like in the test suite.
For the latter, I'd ask you to set up the codspeed integration and test out triggering by PRs.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels