Skip to content

Commit 5ebad6e

Browse files
fix : fix loadUserByUsername to throw errors that only Spring Security defines otherwise a 500 error from it is thrown
1 parent 63a23cb commit 5ebad6e

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

src/main/java/com/patternknife/securityhelper/oauth2/config/security/serivce/userdetail/AdminDetailsService.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
package com.patternknife.securityhelper.oauth2.config.security.serivce.userdetail;
22

33

4-
import com.patternknife.securityhelper.oauth2.config.response.error.exception.data.ResourceNotFoundException;
54
import com.patternknife.securityhelper.oauth2.config.security.dao.OauthClientDetailRepository;
65
import com.patternknife.securityhelper.oauth2.config.security.principal.AccessTokenUserInfo;
76
import com.patternknife.securityhelper.oauth2.config.security.principal.AdditionalAccessTokenUserInfo;
@@ -20,6 +19,7 @@
2019
import org.springframework.security.core.authority.AuthorityUtils;
2120
import org.springframework.security.core.userdetails.UserDetails;
2221
import org.springframework.security.core.userdetails.UserDetailsService;
22+
import org.springframework.security.core.userdetails.UsernameNotFoundException;
2323
import org.springframework.stereotype.Service;
2424

2525
import java.util.ArrayList;
@@ -54,7 +54,7 @@ public void setEntityManager(EntityManager entityManager) {
5454
@Override
5555
public UserDetails loadUserByUsername(String username){
5656

57-
Admin admin = adminRepository.findByIdName(username).orElseThrow(() -> new ResourceNotFoundException("Admin (ID : \"" + username + "\") NOT found."));
57+
Admin admin = adminRepository.findByIdName(username).orElseThrow(() -> new UsernameNotFoundException("Admin (ID : \"" + username + "\") NOT found."));
5858
if(admin.getDeletedAt() != null){
5959
throw new DisabledException(admin.getIdName() + "'s account is currently disabled.");
6060
}

src/main/java/com/patternknife/securityhelper/oauth2/config/security/serivce/userdetail/CustomerDetailsService.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22

33

44
import com.patternknife.securityhelper.oauth2.config.response.error.exception.auth.UserDeletedException;
5-
import com.patternknife.securityhelper.oauth2.config.response.error.exception.data.ResourceNotFoundException;
65
import com.patternknife.securityhelper.oauth2.config.security.dao.OauthClientDetailRepository;
76
import com.patternknife.securityhelper.oauth2.config.security.principal.AccessTokenUserInfo;
87
import com.patternknife.securityhelper.oauth2.config.security.principal.AdditionalAccessTokenUserInfo;
@@ -20,6 +19,7 @@
2019
import org.springframework.security.core.authority.AuthorityUtils;
2120
import org.springframework.security.core.userdetails.UserDetails;
2221
import org.springframework.security.core.userdetails.UserDetailsService;
22+
import org.springframework.security.core.userdetails.UsernameNotFoundException;
2323
import org.springframework.stereotype.Service;
2424

2525
import java.util.ArrayList;
@@ -54,7 +54,7 @@ public void setEntityManager(EntityManager entityManager) {
5454
@Override
5555
public UserDetails loadUserByUsername(String username) {
5656

57-
Customer customer = customerRepository.findByIdName(username).orElseThrow(() -> new ResourceNotFoundException("Customer (ID : \"" + username + "\") NOT foUND"));
57+
Customer customer = customerRepository.findByIdName(username).orElseThrow(() -> new UsernameNotFoundException("Customer (ID : \"" + username + "\") NOT foUND"));
5858
if(customer.getDeletedAt() != null){
5959
if(customer.getDeleteAdminId() == null) {
6060
if (customer.getOneWeekAfterDeletedAsString() != null) {

0 commit comments

Comments
 (0)