fix out of bounds panic when regex filter is applied after file grows

Indices beyond the continuation map have no continuation data and
are treated as standalone lines.

Author: Paulo Remoli

ARCHITECTURE.md

@@ -12,18 +12,19 @@ logana is structured around a strict separation between domain logic and the UI
 
 **Filter Pipeline** (`filters/`) — `FilterManager` compiles filter definitions into Aho-Corasick automata or regexes and evaluates them against every line to produce a visibility bitmap. The pipeline runs in a background thread. Filter definitions are persisted to SQLite and reloaded on startup.
 
-**Mode System** (`mode/`) — Modal UI where each mode owns keyboard input and returns a `KeyResult` for effects that cross mode boundaries. Modes: Normal, Command, Search, Filter, Visual, Comment, Select Fields, DLT Select, Docker Select, Merge Select, Keybindings Help.
+**Mode System** (`mode/`) — Modal UI where each mode owns keyboard input and returns a `KeyResult` for effects that cross mode boundaries. Example of modes: Normal, Command, Search, Filter, Visual, Comment. Each window is also treated as a mode.
 
 **UI & Rendering** (`ui/`) — The renderer reads tab state and produces widgets each frame; it never mutates state. The event loop dispatches key events to the active mode. Session state is persisted to SQLite and restored on reopen.
 
-**Persistence** (`db/`) — `Database` owns the SQLite connection and schema migrations. `LogManager` builds `FilterManager` instances from persisted filter definitions and manages session state.
+**Persistence** (`db/`) — `Database` owns the SQLite connection and schema migrations. Storage is accessed through four traits: `FilterStore` (filter definitions), `FileContextStore` (per-file scroll/search/display context), `SessionStore` (open file list), and `AppSettingsStore` (runtime toggles keyed by `SettingsKey`). `LogManager` builds `FilterManager` instances from persisted filter definitions. `MarkManager` and `CommentManager` are in-memory managers owned by `TabState`; their state is flushed to SQLite via `FileContext` on tab close/switch. Session save/restore is coordinated by `SessionManager` in `ui/session.rs`.
 
 ## Component Diagram
 
 ```mermaid
 graph TD
     CLI[CLI / main.rs] -->|creates| App[App]
     App -->|owns| Tab[TabState ×N]
+    App -->|owns| Session[SessionManager]
     App -->|renders via| Renderer[Renderer]
     Tab -->|owns| Scroll[ScrollState]
     Tab -->|owns| Filter[FilterState]
@@ -32,11 +33,14 @@ graph TD
     Tab -->|owns| Stream[StreamState]
     Tab -->|owns| Display[DisplayConfig]
     Tab -->|owns| Interaction[InteractionState]
+    Tab -->|owns| Marks[MarkManager]
+    Tab -->|owns| Comments[CommentManager]
     Tab -->|owns| FileReader[FileReader]
     Tab -->|owns| LogManager[LogManager]
     Filter -->|holds| FM[FilterManager]
     Display -->|holds| Parser[LogFormatParser]
-    LogManager -->|queries| DB[(SQLite DB)]
+    LogManager -->|FilterStore| DB[(SQLite DB)]
+    Session -->|FileContextStore / SessionStore / AppSettingsStore| DB
     FileReader -->|reads| Files[(Log files / stdin / streams)]
     Renderer -->|reads| Tab
     App -->|snapshot| MCP[MCP Server]
@@ -67,7 +71,7 @@ Live updates are driven by `advance_merged_tabs`, which compares per-source line
 
 ## Commands
 
-`src/commands/` contains clap-derived command definitions shared across layers. `src/ui/commands/` contains the handlers that execute `:` commands, split into `filter.rs`, `io.rs`, `display.rs`, `stream.rs`, and `merge.rs`.
+`src/commands/` contains clap-derived command definitions shared across layers. `src/ui/commands/` contains the handlers that execute `:` commands.
 
 ## MCP Server
 
@@ -170,18 +174,22 @@ graph TD
 | **ratatui** | TUI rendering |
 | **crossterm** | Terminal I/O, key events |
 | **tokio** | Async runtime |
+| **async-trait** | Async trait methods for the mode system |
 | **memchr** | SIMD byte scanning for line indexing |
 | **aho-corasick** | Literal substring filter matching |
 | **regex** | Regex filter matching |
 | **rayon** | Parallel line indexing and visibility scan |
 | **sqlx** | SQLite async driver |
 | **clap** | CLI argument parsing |
-| **serde / serde_json** | Config and theme serialisation |
+| **serde / serde_json / serde_with** | Config and theme serialisation |
+| **schemars** | JSON Schema generation for config |
+| **strum** | Enum-to-string and string-to-enum derives |
 | **time** | Timestamp parsing for date-range filters |
 | **unicode-width** | Unicode display width for cursor/truncation |
 | **arboard** | Clipboard |
-| **dirs** | XDG data directory for SQLite path |
+| **dirs** | XDG config and data directories |
 | **anyhow** | Error handling |
+| **libc** | Low-level OS interfaces |
 | **tempfile** | Temporary files for archive extraction and stdin streaming |
 | **flate2** | Gzip / deflate decompression |
 | **zip** | ZIP archive parsing |
@@ -190,5 +198,6 @@ graph TD
 | **tar** | Tar archive iteration |
 | **rmcp** | MCP server implementation |
 | **axum** | HTTP transport for MCP |
+| **tonic** | gRPC transport for OTLP receiver |
 | **opentelemetry-proto** | OTLP protobuf types |
 | **prost** | Protobuf decoding |

CHANGELOG.md

@@ -6,7 +6,12 @@ All notable changes to logana will be documented in this file.
 ## [Unreleased]
 
 ### Added
-- Export window: `:export` now opens an interactive window when the template footer contains `{{placeholder}}` variables. The window renders one editable field per placeholder, so custom templates with any field names work automatically. Both bundled templates (`markdown` and `jira`) ship with `{{conclusion}}` and `{{next_steps}}` in their footer.
+- Export windows allows filling the placeholders from the template (e.g. Context, next steps and conclusion).
+- Merge view: merge different source into a single view sorted by timestamp.
+- Generate JSON schema for config file validation.
+
+### Fixed
+- Panic (index out of bounds) when applying a regex filter after the log file grew past the size it had when the continuation map was built.
 
 ## [0.5.1] - 2026-04-02
 

src/ui/tab_state/mod.rs

@@ -514,21 +514,32 @@ pub fn apply_continuation_correction(
 
     let n = cmap.len();
 
+    // Indices beyond the map belong to lines appended after the map was built
+    // (e.g. file grew while the map was stale). Preserve them unchanged.
     let mut filter_visible = vec![0u8; n];
     for &idx in indices.iter() {
-        filter_visible[idx] = 1;
+        if idx < n {
+            filter_visible[idx] = 1;
+        }
     }
 
     // Each line is visible iff its parent is visible AND
     // (the line itself was not explicitly excluded OR include filters exist).
     // For parent lines (i == parent) this reduces to filter_visible[i] unchanged.
-    let new_indices: Vec<usize> = (0..n)
+    let mut new_indices: Vec<usize> = (0..n)
         .into_par_iter()
         .filter(|&i| {
             filter_visible[cmap[i]] != 0 && (filter_visible[i] != 0 || has_include_filters)
         })
         .collect();
 
+    for &idx in indices.iter() {
+        if idx >= n {
+            new_indices.push(idx);
+        }
+    }
+    new_indices.sort_unstable();
+
     *indices = new_indices;
 }
 
@@ -4160,6 +4171,23 @@ mod tests {
         assert!(visible.contains(&3), "line 3 must be visible");
     }
 
+    /// Regression test: `apply_continuation_correction` must not panic when the
+    /// visible-index list contains indices that lie beyond the continuation map
+    /// (i.e. the file grew after the map was built).
+    #[test]
+    fn test_continuation_correction_indices_beyond_cmap() {
+        // cmap covers 3 lines (indices 0-2); all are their own parent.
+        let cmap = vec![0usize, 1, 2];
+        // visible contains index 3, which is beyond cmap — simulates a file that
+        // gained a new line after the map was built.
+        let mut visible = VisibleLines::Filtered(vec![0, 1, 2, 3]);
+        // Must not panic.
+        apply_continuation_correction(&mut visible, &cmap, false);
+        let result: Vec<usize> = visible.iter().collect();
+        // All four lines should be visible and in order.
+        assert_eq!(result, vec![0, 1, 2, 3]);
+    }
+
     #[tokio::test]
     async fn test_filter_match_counts_updated_via_advance() {
         let mut tab = make_tab(&["ERROR line", "INFO line", "ERROR again"]).await;