chore(types): simplify createInstance() generic (#731)

Author: gregjopa

.changeset/thick-books-lie.md

@@ -0,0 +1,5 @@
+---
+"@paypal/paypal-js": minor
+---
+
+simplify createInstance generic type for v6

packages/paypal-js/types/v6/index.d.ts

@@ -28,7 +28,7 @@ export interface PayPalV6Namespace {
      * });
      * ```
      */
-    createInstance: <T extends readonly [Components, ...Components[]]>(
+    createInstance: <T extends readonly Components[]>(
         createInstanceOptions: CreateInstanceOptions<T>,
     ) => Promise<SdkInstance<T>>;
     version: `${number}.${number}.${number}`;
@@ -119,18 +119,15 @@ export type CreateInstanceOptions<T extends readonly Components[]> = {
  * sdkInstance.updateLocale("es-US");
  * ```
  */
-export type SdkInstance<T extends readonly [Components, ...Components[]]> =
-    BaseInstance &
-        ("paypal-payments" extends T[number]
-            ? PayPalPaymentsInstance
-            : unknown) &
-        ("paypal-guest-payments" extends T[number]
-            ? PayPalGuestPaymentsInstance
-            : unknown) &
-        ("venmo-payments" extends T[number] ? VenmoPaymentsInstance : unknown) &
-        ("paypal-legacy-billing-agreements" extends T[number]
-            ? PayPalLegacyBillingInstance
-            : unknown);
+export type SdkInstance<T extends readonly Components[]> = BaseInstance &
+    ("paypal-payments" extends T[number] ? PayPalPaymentsInstance : unknown) &
+    ("paypal-guest-payments" extends T[number]
+        ? PayPalGuestPaymentsInstance
+        : unknown) &
+    ("venmo-payments" extends T[number] ? VenmoPaymentsInstance : unknown) &
+    ("paypal-legacy-billing-agreements" extends T[number]
+        ? PayPalLegacyBillingInstance
+        : unknown);
 
 /**
  * @internal

packages/paypal-js/types/v6/tests/many-components.test.ts

@@ -0,0 +1,51 @@
+import { loadCoreSdkScript } from "../../../src/v6";
+import type { PayPalV6Namespace } from "../index";
+
+// eslint-disable-next-line @typescript-eslint/no-unused-vars
+async function main() {
+    let paypal: PayPalV6Namespace | null;
+
+    try {
+        paypal = await loadCoreSdkScript({
+            environment: "sandbox",
+            debug: true,
+        });
+    } catch (err) {
+        throw new Error(`Failed to load the paypal sdk script: ${err}`);
+    }
+
+    if (!paypal?.createInstance) {
+        throw new Error("Invalid paypal object for v6");
+    }
+
+    if (!paypal?.version) {
+        throw new Error("PayPal v6 namespace missing version property");
+    }
+
+    const sdkInstance = await paypal.createInstance({
+        clientToken: "fakeValue",
+        components: [
+            "paypal-payments",
+            "paypal-guest-payments",
+            "venmo-payments",
+        ],
+    });
+
+    sdkInstance.createPayPalOneTimePaymentSession({
+        onApprove() {
+            return Promise.resolve();
+        },
+    });
+
+    sdkInstance.createPayPalGuestOneTimePaymentSession({
+        onApprove() {
+            return Promise.resolve();
+        },
+    });
+
+    sdkInstance.createVenmoOneTimePaymentSession({
+        onApprove() {
+            return Promise.resolve();
+        },
+    });
+}