Skip to content

Commit e471ace

Browse files
committed
fw: rename BT tasks
So that they better reflect its current usage. Signed-off-by: Gerard Marull-Paretas <gerard@teslabs.com>
1 parent e3e40a8 commit e471ace

File tree

5 files changed

+19
-19
lines changed

5 files changed

+19
-19
lines changed

src/bluetooth-fw/nimble/init.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ void bt_driver_init(void) {
9090
.puxStackBuffer = NULL,
9191
};
9292

93-
pebble_task_create(PebbleTask_BTCallback, &host_task_params, &s_host_task_handle);
93+
pebble_task_create(PebbleTask_BTHost, &host_task_params, &s_host_task_handle);
9494
PBL_ASSERTN(s_host_task_handle);
9595

9696
#if NIMBLE_CFG_CONTROLLER
@@ -102,7 +102,7 @@ void bt_driver_init(void) {
102102
.puxStackBuffer = NULL,
103103
};
104104

105-
pebble_task_create(PebbleTask_BTRX, &ll_task_params, &s_ll_task_handle);
105+
pebble_task_create(PebbleTask_BTController, &ll_task_params, &s_ll_task_handle);
106106
PBL_ASSERTN(s_ll_task_handle);
107107
#endif
108108
}

src/fw/comm/bt_lock.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
// *and* by Bluetopia. It gets handed to Bluetopia using bt_lock_get() in
2525
// BTPSKRNL.c when Bluetopia is initialized. The firmware uses this lock to
2626
// protect Bluetooth-related state that is read and written from the Bluetooth
27-
// callback task (PebbleTask_BTCallback) and other tasks. If we created our
27+
// callback task (PebbleTask_BTHost) and other tasks. If we created our
2828
// own mutex for this purpose, we would encounter dead-lock situations.
2929
// For example:
3030
// Task1: Bluetopia code -> grabs BT stack lock -> Pebble callback -> grabs pebble mutex

src/fw/kernel/pebble_tasks.c

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -66,11 +66,11 @@ char pebble_task_get_char(PebbleTask task) {
6666
return 'w';
6767
case PebbleTask_App:
6868
return 'a';
69-
case PebbleTask_BTCallback:
69+
case PebbleTask_BTHost:
7070
return 'b';
71-
case PebbleTask_BTRX:
71+
case PebbleTask_BTController:
7272
return 'c';
73-
case PebbleTask_BTTimer:
73+
case PebbleTask_BTHCI:
7474
return 'd';
7575
case PebbleTask_NewTimers:
7676
return 't';
@@ -122,11 +122,11 @@ void analytics_external_collect_stack_free(void) {
122122
prv_task_get_stack_free(PebbleTask_KernelBackground), AnalyticsClient_System);
123123

124124
analytics_set(ANALYTICS_DEVICE_METRIC_STACK_FREE_BLUETOPIA_BIG,
125-
prv_task_get_stack_free(PebbleTask_BTCallback), AnalyticsClient_System);
125+
prv_task_get_stack_free(PebbleTask_BTHost), AnalyticsClient_System);
126126
analytics_set(ANALYTICS_DEVICE_METRIC_STACK_FREE_BLUETOPIA_MEDIUM,
127-
prv_task_get_stack_free(PebbleTask_BTRX), AnalyticsClient_System);
127+
prv_task_get_stack_free(PebbleTask_BTController), AnalyticsClient_System);
128128
analytics_set(ANALYTICS_DEVICE_METRIC_STACK_FREE_BLUETOPIA_SMALL,
129-
prv_task_get_stack_free(PebbleTask_BTTimer), AnalyticsClient_System);
129+
prv_task_get_stack_free(PebbleTask_BTHCI), AnalyticsClient_System);
130130

131131
analytics_set(ANALYTICS_DEVICE_METRIC_STACK_FREE_NEWTIMERS,
132132
prv_task_get_stack_free(PebbleTask_NewTimers), AnalyticsClient_System);
@@ -172,9 +172,9 @@ void pebble_task_create(PebbleTask pebble_task, TaskParameters_t *task_params,
172172
break;
173173
case PebbleTask_KernelMain:
174174
case PebbleTask_KernelBackground:
175-
case PebbleTask_BTCallback:
176-
case PebbleTask_BTRX:
177-
case PebbleTask_BTTimer:
175+
case PebbleTask_BTHost:
176+
case PebbleTask_BTController:
177+
case PebbleTask_BTHCI:
178178
case PebbleTask_NewTimers:
179179
case PebbleTask_PULSE:
180180
mpu_init_region_from_region(&app_region, memory_layout_get_app_region(),
@@ -200,9 +200,9 @@ void pebble_task_create(PebbleTask pebble_task, TaskParameters_t *task_params,
200200
case PebbleTask_KernelBackground:
201201
stack_guard_region = memory_layout_get_kernel_bg_stack_guard_region();
202202
break;
203-
case PebbleTask_BTCallback:
204-
case PebbleTask_BTRX:
205-
case PebbleTask_BTTimer:
203+
case PebbleTask_BTHost:
204+
case PebbleTask_BTController:
205+
case PebbleTask_BTHCI:
206206
case PebbleTask_NewTimers:
207207
case PebbleTask_PULSE:
208208
break;

src/fw/kernel/pebble_tasks.h

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,9 +31,9 @@ typedef enum PebbleTask {
3131
PebbleTask_Worker,
3232
PebbleTask_App,
3333

34-
PebbleTask_BTCallback, // Task Bluetooth callbacks are handled on
35-
PebbleTask_BTRX, // Task handling inbound data from BT controller
36-
PebbleTask_BTTimer, // Timer task - only used by cc2564x BT controller today
34+
PebbleTask_BTHost, // Bluetooth Host
35+
PebbleTask_BTController, // Bluetooth Controller
36+
PebbleTask_BTHCI, // Bluetooth HCI
3737

3838
PebbleTask_NewTimers,
3939

third_party/nimble/transport/hci_uart_transport.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -202,7 +202,7 @@ void ble_transport_ll_init(void) {
202202
.puxStackBuffer = NULL,
203203
};
204204

205-
pebble_task_create(PebbleTask_BTRX, &task_params, &s_rx_task_handle);
205+
pebble_task_create(PebbleTask_BTHCI, &task_params, &s_rx_task_handle);
206206
PBL_ASSERTN(s_rx_task_handle);
207207

208208
if (ble_chipset_start()) {

0 commit comments

Comments
 (0)