Fix unit tests that fail to compile

[Colin-Suckow]

Summary

A number of the unit tests fail to compile, preventing waf test from running. This issue covers resolving the build issues stopping the tests in 'BROKEN_TESTS' from running. Specifically

• test_app_fetch_endpoint.c
• test_graphics_draw_text_flow.c
• test_perimeter.c
• test_ancs_pebble_actions.c
• test_timeline_actions.c
• test_bluetooth_persistent_storage_prf.c
• test_bluetooth_persistent_storage.c
• test_session.c
• test_session_receive_router.c
• test_compositor.c
• test_floor.c
• test_pow.c
• test_ams.c
• test_ams_util.c
• test_gap_le_advert.c
• test_bt_conn_mgr.c
• test_gatt_client_accessors.c
• test_gatt_client_discovery.c
• test_gatt_client_subscriptions.c
• test_gatt_service_changed_client.c
• test_gatt_service_changed_server.c
• test_gap_le_connect.c
• test_ancs_util.c
• test_ancs.c
• test_kernel_le_client.c
• test_ppogatt.c

End State

./waf test should be able tun run the test suite when all tests are removed from the bld.env.BROKEN_TESTS list.

[waldyrious]

How does this issue differ from #46? And how does it relate to #69? (I think I could sort of piece the answers together from the discussion in #69, but I don't want to make assumptions.)

[Colin-Suckow]

How does this issue differ from #46? And how does it relate to #69? (I think I could sort of piece the answers together from the discussion in #69, but I don't want to make assumptions.)

Good question. #46 is about ./waf test failing to run at all. In #69 we fixed the issues stopping the test suite, but that exposed a number of tests that can't compile due to a variety of issues. Instead of ballooning #69 into a PR that tries to fix a bunch of different issues, we created this issue to cover fixing the specific broken tests.