Release 1.4: Common tasks, Dev acknowledgement, versioning, helper packages/websites, etc #2394
Replies: 11 comments 6 replies
This comment has been hidden.
This comment has been hidden.
This comment has been hidden.
This comment has been hidden.
This comment has been hidden.
This comment has been hidden.
-
|
Cool Issue Template - https://github.com/insightsengineering/teal/issues/new?assignees=KlaudiaBB%2Ccicdguy&labels=release&projects=&template=release.yml&title=%5BRelease%5D%3A+%3Cversion%3E |
Beta Was this translation helpful? Give feedback.
-
|
Making note here on cheatsheet - needs a little more thought on when to update #2600 |
Beta Was this translation helpful? Give feedback.
-
|
I don't know what this means? @manciniedoardo |
Beta Was this translation helpful? Give feedback.
-
|
@bms63 I wouldn't worry about the qpdf and latex warnings. If you want, you can install it on your machine to avoid the message. Resolving the latex warning will depend on how the latex distribution on your machine, so I would just ignore it. These both arise from building the PDF manual, which CRAN does on their end anyway. Has the size of the package grown since the last release? Unless the rules have changed, you may be auto-rejected because the build is >5MB. But I know there are packages that exceed this size on CRAN, but I have never gone through that process. 🤷🏼 |
Beta Was this translation helpful? Give feedback.
-
Sniff out unicode characters in .Rd filessearch_specific_unicode_in_rd_files <- function(folder_path, unicode_char) { List all
|
Beta Was this translation helpful? Give feedback.
-
|
@1mgroot @gg106046 @ddsjoberg @cicdguy @SolveigHolmgaard This is just a courtesy notification that as per our internal guidelines, for the 1.4 release we will be moving your names from the authors section of the DESCRIPTION file to the acknowledgements section of the README, because you have not been involved with the package during the 1.3 release cycle. Of course, if in future your involvement with admiral picks up again, we'll be happy to re-add you as authors. |
Beta Was this translation helpful? Give feedback.
-
Jan 12, 2026 Deep Dive WG - Gemini notesSummary@mancinie, @millerg23, @adcascone, @bundfussr, @bms63, @jeffreyad, and other participants discussed the issue of the Details{admiral} Package Size Concern@mancinie and @millerg23 opened the meeting by addressing the size of the Causes for Package Size Increase@bundfussr and @millerg23 discussed potential reasons for the increased package size, which was unexpected since Excel files were replaced with JSON files. @mancinie calculated that the package gained about 200 kilobytes. @bundfussr suggested that the new vignettes for ADAB might be a factor, with @mancinie identifying a 14 kilobyte file as "by far the biggest," suggesting the package may have just crossed the size barrier. Strategies for Size ReductionThe participants discussed options for reducing the package size, including seeking an exemption from CRAN or cutting package content. @adcascone proposed moving templates, specifically the ADAB template, to a separate package, though @mancinie noted that ADAB is the only particularly large template. @bundfussr calculated that templates were less than 100 kilobytes, suggesting minimal gain from moving them. @mancinie suggested that the Immediate Solution with Compression@adcascone suggested implementing BZIP2 compression for RDA files created from ATOX GR sources. @mancinie ran a test and determined that applying the BZIP2 compression reduced the size by 0.25 megabytes (from 0.49 to 0.24). @bms63 confirmed that this reduction would be enough to bring the package under the 5.1 megabyte limit for the current release. Long-Term Package Size StrategyThe team agreed that while the compression fix would work for this release, a longer-term strategy is needed. @bundfussr suggested reducing the size of Discussion on Time-to-Event Functionality (TTE)@bms63 initiated a discussion on potential changes for the 1.5 release, specifically regarding the TTE function, aiming to make it more flexible for estimand strategies. @bundfussr and @bms63 agreed that the estimand (ESTIM) topic should be a separate discussion and vignette from the TTE function updates. @bundfussr emphasized the need to investigate what "more flexible" means, including different scenarios like negative and positive events or composite endpoints. @bms63 proposed gathering more scenarios from Slack to inform decisions on whether to update the existing Estimand Guidance and Vignettes@bundfussr mentioned that TTE derivation often involves intermediate datasets like ARS or AD event. @millerg23 stressed identifying scenarios before creating new functions. @bms63 inquired about open-sourcing an internal estimand guidance document, and @mancinie agreed to check with Ross. Release Process and Next Steps@bms63 confirmed that the Suggested next steps
|
Beta Was this translation helpful? Give feedback.
-
|
Quick note on 404 to check |
Beta Was this translation helpful? Give feedback.


Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
Master PR
Common Release Tasks
All of these small Release Tasks should be done in one issue and not split out across multiple issues and PRs. I have created a common task list for us to check and hope to develop the task (if needed) below. If we can standardized this stuff, then we could build a
release_functionthat is a wrapper around the https://usethis.r-lib.org/reference/use_release_issue.htmlPrepare for release:
urlchecker::url_check()checked as of 19th Junedevtools::check(remote = TRUE, manual = TRUE)output as of 19th June:devtools::check_win_devel()- doesn't work with RemtoesSubmit to CRAN:
usethis::use_version('major')devtools::submit_cran()usethis::??CRAN Accepted:
usethis::use_github_release()usethis::use_dev_version()Loose Guidance for particular tasks
New presentations
pharmaverse/admiraldiscovery#64
News devs to description File and old devs to acknowledgements - NB: check admiraldev as well
#2748
pharmaverse/admiraldev#492
Devs to moved to acknowledgments (not actively working on admiral anymore) at the bottom of README:
New acknowledgements
Review FAQs
Polish News
Beta Was this translation helpful? Give feedback.
All reactions