Replies: 16 comments 19 replies
-
August 4, 2025 Team Meeting - Gemini notesSummaryBen Straub reported that a fix for a CRAN issue caused a temporary website deployment problem, while Edoardo Mancini updated the team on exploring an open-source AI assistant for documentation and noted an issue with the farmer blog's deployment due to website versioning problems. The team decided to maintain the conservative approach for the DetailsCRAN Issue and Website DeploymentBen Straub reported that a fix for a CRAN issue, primarily concerning documentation links, has been released, noting that CRAN often requests such updates to encourage package maintenance. This update caused a temporary issue with the website's deployment. Arianna Cascone inquired about the purpose of having both PDF and HTML manuals on CRAN, to which Ben Straub suggested checking CRAN working group minutes for details. AI Assistant for DocumentationEdoardo Mancini provided an update on exploring an open-source AI assistant trained on their documentation, noting that Tidyverse already uses such an assistant. They reached out to Phil Bowsher at Posit, to gather more information on their implementation. Ben Straub expressed interest in leveraging open-source AI models but acknowledged the potential challenges. Verify Template IssueBen Straub proposed changing the "verify template" process from a pull request action to a weekly cron job to avoid user confusion and simplify the workflow. Jim Rothstein agreed to implement this change, adapting the existing code to run as a cran job and assigning issues to key personnel if mismatches are detected. Ben Straub and Edoardo Mancini will be the recipients of these notifications. Derive Treatment Emergent FlagBen Straub raised a question about the Time Zone HandlingEdoardo Mancini introduced an issue regarding the package's time and date functions defaulting to UTC, and the user's desire for an option to specify other time zones. The team discussed the complexities of time zone conversions, especially with global trials and daylight savings, and decided to wait for the user to provide a more detailed use case before investigating further. Ben Straub noted that their vendor data is typically already converted to UTC before it reaches the atom level. Derive Duration RoundingBen Straub inquired about the rounding of durations from the Unassigned Issues and Documentation EnhancementsEdoardo Mancini encouraged team members, particularly new starters like Ramesh Potluri, to take on unit test issues to increase test coverage. They also highlighted the ongoing effort to enhance reference page documentation, inviting contributions to improve examples for existing functions. Fanny Gautier volunteered to work on the Admiral IG Working GroupBen Straub announced that Arianna Cascone will lead the Admiral IG working group, which aims to cross-check Admiral with the CDISC implementation guide to ensure alignment. Arianna Cascone expressed enthusiasm for the opportunity to learn more about the standards and plans to coordinate with Ben Straub for initial support. RDA vs. RDS File FormatsJim Rothstein raised a point about the use of RDA files, suggesting a standardization of how they are saved and retrieved due to their cumbersome nature compared to RDS files, which directly load into the global environment. Ben Straub acknowledged prior discussions on this topic and requested Jim Rothstein to create an issue outlining a standardized method for working with RDA files. Farmer Blog Deployment IssueEdoardo Mancini noted that the website versioning issues are now preventing the farmer blog from deploying due to failing Admiral links. Ben Straub suggested seeking support for this custom insight engineering website versioning issue and questioned whether reverting to the original package down deployment might be necessary if support is not forthcoming. Next Steps
|
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
-
August 18, 2025 Team Meeting - Gemini notesSummaryBen Straub provided updates on working groups, including aligning Admiral with CDISC standards, and discussed environments with Edoardo Mancini and Stefan Pascal Thoma to understand their impact. Stefan Bundfuss recommended running template verification even when "skip v bump" is used for releases, while Edoardo Mancini requested Jim commit their code for review. The team confirmed consensus not to pursue time zones with derive functions due to a lack of clear use cases and discussed standard conventions for ADaM and SDTM variables. Stefan Bundfuss raised a user request to refine the DetailsWorking Group Updates Ben Straub shared updates regarding the working groups, mentioning a meeting with CDISC folks on the 27th to discuss aligning Admiral with CDISC standards. Ariana Cascone is set to help lead the group to ensure alignment and improvement. Environments Discussion Ben Straub noted that he, Edoardo Mancini, and Stefan Bundfuss met to discuss environments and their impact on Admiral. Stefan Pascal Thoma inquired about the issue, to which Ben Straub explained they are trying to better understand environments and fill knowledge gaps. Stefan Pascal Thoma plans to join future meetings on this topic. Verify Templates Status Edoardo Mancini inquired about the status of the "verify templates" item, which Ben Straub confirmed was almost clsoed. Jim has developed a job that runs the verification, and Edoardo Mancini suggested that this job be run weekly or bi-weekly and its code committed. Stefan Pascal Thoma clarified that issues should only be created if problems are found, not for all-green results. Stefan Bundfuss suggested that the workflow for verifying templates should also run when "skip v bump" is used for releases, ensuring all templates are fine. Ben Straub suggested creating a separate issue for this to avoid distracting Jim from the current task of getting the initial template verification running. Edoardo Mancini asked Jim to commit their code for review and merging by the end of the week, with the "skip v bump" addition to be explored later. Ignore Seconds Flag and ADAB Template Request Edoardo Mancini reported that Jeff, who was supposed to provide an update on the "ignore seconds flag" item, declined the meeting last minute, so discussions would continue in the PR. Additionally, Jeff requested a new ADAB template, and Ben Straub offered to ping Kirsten for an update on the draft PR. Time Zones with Derive Functions The team revisited the discussion about time zones with derive functions like *Standardizing ADaM and SDTM convention (--DTC and DTM) Ben Straub raised a question about standard conventions for ADaM and SDTM variables, noting that Stefan Bundfuss confirmed a convention where a dash is used for STMM and a star for Atom variables. Ben Straub stated they would take the issue to explore how to standardize these variables across the code. **is_valid_DTC() Function Refinement ** Stefan Bundfuss brought up a user's request to refine the pharmaversesdtm and adam Release Plans Fanny Gautier provided an update on pharmaversesdtm release plans, mentioning an upcoming release for maintainer change and data refresh. She noted that some updates are blocked by issues in admiralvaccine and admiralmetabolic templates. Edoardo Mancini offered to address the admiralvaccine e template issue if needed, as Fanny Gautier would not have time. Fanny Gautier indicated that pharmaversesdtm is planned for release soon, with phamraverseadam to follow in early September once issues are closed and approvals are secured. Stefan Bundfuss offered to review the outstanding issues. Fanny Gautier discussed Jim's PR on pharmaverseadam, which would cause conflicts with ongoing updates. She proposed closing Jim's PR and adding Jim as a reviewer to her updates, as they address similar issues and would prevent conflicts. Customizing the Linter File Edoardo Mancini initiated a discussion about further customizing the linter file to enforce coding standards, suggesting that custom lints could ensure consistent use of functions like CLI for error messaging instead of French Presentation Recording Fanny Gautier asked if a presentation she is giving in French for a public hospital in October should be recorded and if material in French would be useful for the Admiral team. Edoardo Mancini and Ben Straub agreed it would be valuable, and Edoardo Mancini suggested adding it to the presentation archive with a language note. Next steps
|
Beta Was this translation helpful? Give feedback.
-
September 15th 2025
|
Beta Was this translation helpful? Give feedback.
-
September 15, 2025 Team Meeting - Gemini notesSummaryFanny Gautier is preparing a French presentation on Admiral for October 15th, and Edoardo Mancini noted that Admiral will still have a presence at the R-Pharma workshop despite no Admiral workshop taking place due to lack of volunteers. Arianna Cascone reported positive progress on the CDISC Admiral collaboration for ADaM IG review, while Ben Straub initiated a discussion on the DetailsFrench Admiral PresentationFanny Gautier is preparing a French presentation on Admiral, scheduled for October 15th at 2 PM CET. She plans to include four slides covering an introduction to Admiral, the Admiral family, installation, and how to get started, followed by a live demo. R-Pharma Workshop StatusThe R-Pharma admiral workshop will likely not proceed this year due to team availability and lack of interest. Edoardo Mancini noted that Admiral will still have a presence at the event, as their talk proposal was accepted. CDISC Admiral Collaboration for ADaM IG ReviewArianna Cascone provided an update on the CDISC Admiral collaboration, reporting a positive response from the ADaM working group for their first meeting on October 1st. The collaboration aims to review the ADaM IG alongside Admiral, identifying gaps and seeking clarifications for documentation. Part-Time Package DiscussionBen Straub initiated a discussion on the Unit Tests for Datetime FunctionsFanny Gautier raised concerns about crashes in the Admiralvaccine template due to changes in the Admiral Template Clean-upEdoardo Mancini issued an open call for assistance in cleaning up the Admiral Template repository, which is used for creating new Admiral extension packages. Ramesh Potluri volunteered to help with the template cleanup and will connect with Edoardo Mancini for further guidance. Linter Customization in Admiral DevEdoardo Mancini presented findings on Admiral Package AssessmentBen Straub shared an interesting package assessment tool from Jumping Rivers, noting that Admiral scored well, comparable to Admiral Neuro Release and pharmaverseadamEdoardo Mancini reported that Admiralneuro has been released, but a Cran check related to template saving requires a fix that will be re-changed in a subsequent release. Fanny Gautier noted that pharmaverseadam is reading ADSL data from an older CRAN release instead of the latest development version, which will be investigated as an issue. |
Beta Was this translation helpful? Give feedback.
-
September 29th, 2025 AgendaTopics:
|
Beta Was this translation helpful? Give feedback.
-
October 13th
|
Beta Was this translation helpful? Give feedback.
-
October 27th |
Beta Was this translation helpful? Give feedback.
-
November 11th
|
Beta Was this translation helpful? Give feedback.
-
November 24th
|
Beta Was this translation helpful? Give feedback.
-
November 24, 2025 Team Meeting - Gemini notesSummary@bundfussr and @bms63 discussed the issue of Details
|
Beta Was this translation helpful? Give feedback.
-
December 8th
|
Beta Was this translation helpful? Give feedback.
-
8th Dec Team Meeting - Gemini notesSummaryThe team, including @jeffreyad, @mancinie, @bms63, @bundfussr, @Fanny-Gautier, @adcascone, and Ramesh Potluri, prioritized the ADAB template over the vignette and discussed gathering external feedback for the template, with Jeffrey Dickinson planning to check with the CDISC ADaM working group. Participants also addressed issues with the Key topics included the {admiral} 1.4 release checklist with @mancinie leading the progression and @adcascone offering to help, the need for a function for nominal time conversion proposed by @jeffreyad, and the importance of documenting attribute preservation in functions. @bundfussr and @bms63 agreed to fix an issue regarding row-wise operations potentially tricking the duplicates check for the 1.5 release. DetailsADAB Template and Vignette PrioritizationThe team confirmed the priority is on the ADAB template over the vignette. @jeffreyad noted that ADAB Template Feedback and Outreach@jeffreyad is planning to check with the CDISC ADaM working group to gather more information and feedback, especially from those outside the RO side, as most current feedback is internal. @bms63 suggested including a note in a potential blog post or news announcement asking for feedback on this first template.
|
Beta Was this translation helpful? Give feedback.
-
22nd Dec Team Meeting - Gemini notesSummary Ben Straub reported that Matt Burnham is no longer on the team, requiring Ben Straub to consider taking over the summary record args PR, which Stefan Bundfuss offered to review if Ben Straub finalizes it. Kristin Dahnert updated the team on the near-completion of the NFROT and XXTPT functions, and Ben Straub suggested adding an "experimental tag" to allow for future changes, which Kristin Dahnert agreed with and Stefan Bundfuss suggested documenting in the deprecation cycle. Ben Straub and Gordon Miller discussed minimum version misalignments in dependencies between Admiral and Admiral Dev, with Stefan Bundfuss recommending choosing the higher minimum version to avoid issues. Kristin Dahnert raised a marketing concern about template discoverability, and Gordon Miller and Stefan Bundfuss suggested a separate page or tab to list all available templates. Details ADAB Vignette and Admiral Release Planning Kristin Dahnert will update the ADAB vignette code to match the ADAB template and add sample data sets and comments, expecting to finish the work in the next two weeks. Ben Straub confirmed the planned Admiral release date is January 14th, with the week before reserved for internal testing and issue resolution. Kristin Dahnert affirmed that the vignette is in good shape and that the work is feasible for the target release date. Kristin Dahnert also noted that the ADAB template was created to complete the PK teams' set, making an Admiral counterpart to the RO one. Summary Record Args Pull Request (PR) Ben Straub reported that Matt Burnham, who was working on the summary record args PR, is no longer involved with the team at GSK and will not continue work on it. Ben Straub is considering taking over the work, which they noted seemed close to completion, with only missing code comments and a new example needed. Stefan Bundfuss offered to review the PR the next morning if Ben Straub could finish tightening it up. NFROT and XXTPT Functions Kristin Dahnert provided an update on the NFROT and XXTPT functions, confirming they are very close to being ready. The updates included adding a range option for time points, allowing users to select the beginning, mid, or end, and the option to add planned duration. The NFROT function is simpler as it piggybacks off the time point function in XXTPT. Minimum Version Alignment and Dependencies Ben Straub raised concerns about minimum version misalignments in dependencies between Admiral and Admiral Dev, specifically for Template Discoverability Kristin Dahnert raised a marketing concern about the discoverability of templates like the new ADAB one on the Admiral homepage. Stefan Bundfuss suggested that at Roche, they have a separate page to display all available templates, which they could adapt for Admiral. Gordon Miller supported this, noting that Edo at Raj suggested a separate tab on the user manual, "Explore Adam templates," that lists all available templates. Stefan Bundfuss offered to create an issue in Admiral to discuss this with Eduardo. Release Status and Continuous Checks Ben Straub confirmed that the release is planned for January 14th. Gordon Miller stated that they are running continuous checks on Admiral with the latest version as they are doing a lot of internal work on their templates. Ben Straub concluded that despite extensive discussion, the changes for the 1.4 release are relatively minimal compared to previous releases, and they are in good shape. Suggested next steps |
Beta Was this translation helpful? Give feedback.
-
January 5, 2026 Team Meeting - Gemini notesSummaryEdoardo Mancini (@mancinie), Fanny Gautier (@Fanny-Gautier), @Kcdahn, Arianna Cascone (@adcascone), Sadchla Mathieu, Ramesh Potluri, Jeff Dickinson (@jeffreyad), and Gordon Miller (@millerg23) met to review open DetailsReview of Open PRs and Template Updates@mancinie reviewed open PRs, focusing on the NFRT PR from @jeffreyad. @Kcdahn clarified that the NFRLT and NFRT PRs work together to update ADPC, ADPK, and ADAB templates with a new function (likely Template Updates in Data Packages@Fanny-Gautier asked if the NFRT PR updates would impact templates and vignettes in Website Enhancements and Templates Link@mancinie discussed a PR suggested by Stefan Bundfuss (@bundfussr) to add a link to the templates on the
|
Beta Was this translation helpful? Give feedback.
-
|
@pharmaverse/admiral hey all closing in favor of #2953 |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
Beta Was this translation helpful? Give feedback.
All reactions