Merge pull request #57 from php-api-clients/correct-operation-constructor-parameter-types

Correct operation constructor paramter types

Author: WyriHaximus

src/Generator/Client.php

@@ -31,7 +31,7 @@ public static function generate(string $operationGroup, string $namespace, strin
             foreach ($operationDetails['operation']->parameters as $parameter) {
                 $params[] = new Node\Arg(new Node\Expr\Variable($parameter->name));
                 $param = new Param($parameter->name);
-                if ($parameter->schema->default !== null) {
+                if ($parameter->schema->type !== null) {
                     $param->setType(
                         str_replace([
                             'integer',

src/Generator/Operation.php

@@ -54,9 +54,10 @@ public static function generate(string $path, string $method, string $namespace,
         $requestReplaces = [];
         $query = [];
         foreach ($operation->parameters as $parameter) {
-            $paramterStmt = $factory->
-            property($parameter->name)->
-            setDocComment('/**' . (string)$parameter->description . '**/');
+            $paramterStmt = $factory->property($parameter->name);
+            if (strlen((string)$parameter->description) > 0) {
+                $paramterStmt->setDocComment('/**' . (string)$parameter->description . '**/');
+            }
             if ($parameter->schema->type !== null) {
                 $paramterStmt->setType(str_replace([
                     'integer',
@@ -68,10 +69,10 @@ public static function generate(string $path, string $method, string $namespace,
                     'bool',
                 ], $parameter->schema->type));
             }
-            $class->addStmt($paramterStmt);
+            $class->addStmt($paramterStmt->makeReadonly()->makePrivate());
 
             $param = new Param($parameter->name);
-            if ($parameter->schema->default !== null) {
+            if ($parameter->schema->type !== null) {
                 $param->setType(
                     str_replace([
                         'integer',