Reduce number of unit tests

[php-coder]

Check list:

• Implement role testing with molecule #1145 needs a decision
• will drastically reduce a scope of Migrate unit tests away from Spock to JUnit back #1246
• check the current tests and remove non-usefull
  • SlugUtilsTest.groovy
  • LocaleUtilsTest.groovy
  • PagerTest.groovy
  • SeriesSalesServiceImplTest.groovy (resolution: fully remove)
  • CatalogUtilsTest.groovy
  • StampsCatalogServiceImplTest.groovy (resolution: fully remove)
  • SeriesSalesImportServiceImplTest.groovy (resolution: fully remove)
  • SeriesInfoExtractorServiceImplTest.groovy
  • TimedSeriesInfoExtractorServiceTest.groovy (resolution: fully remove)
  • SeriesImportServiceImplTest.groovy (resolution: remove most of the tests)
    • keep addRequest() should throw exception if url is incorrect
    • keep addRequest() should save url in the encoded form
    • keep addRequest() should not encode url if it is already encoded
  • SeriesServiceImplTest.groovy (resolution: remove most of the tests)
    • keep add() should remove image when exception occurs
    • keep addImageToSeries() should remove image when exception occurs
  • CollectionServiceImplTest.groovy (resolution: fully remove)
  • CategoryServiceImplTest.groovy (resolution: fully remove)
  • ParticipantServiceImplTest.groovy (resolution: fully remove)
  • FilesystemImagePersistenceStrategyTest.groovy
  • ImageServiceImplTest.groovy (resolution: remove most of the tests)
    • keep save() should pass content type '#contentType' to image dao (but rename it and emphasize testing of conversion logic)
    • keep save() should pass abbreviated filename when it is too long
  • TimedImagePreviewStrategyTest.groovy (resolution: fully remove)
  • DatabaseImagePersistenceStrategyTest.groovy
  • SiteServiceImplTest.groovy (resolution: remove most of the tests)
    • keep logEvent() should pass abbreviated method when it's too long
    • keep logEvent() should pass abbreviated referer when it's too long
    • keep logEvent() should pass abbreviated user agent when it's too long
    • keep logAboutAbsentPage() should pass abbreviated page when it's too long
  • CronServiceImplTest.groovy
  • SuspiciousActivityServiceImplTest.groovy
  • UsersActivationServiceImplTest.groovy
  • UserServiceImplTest.groovy (resolution: fully remove)
  • CountryServiceImplTest.groovy (resolution: fully remove)
  • JsoupSiteParserTest.java
  • JdbcCategoryDaoTest.java
  • JdbcCountryDaoTest.java
  • ContentSecurityPolicyHeaderWriterTest.java
• remove unused methods from TestObjects, Random and DateUtils classes
• close issues for adding more unit tests
  • check @todo comments
    • ImageService.getOrCreatePreview(): add unit tests #579
    • TestObjects.createAddSeriesDto(): return randomized values #757
    • TimedDownloaderService: add unit tests #800
    • TimedSiteParser: add unit tests #805
    • CategoryServiceImpl.findIdsWhenNameStartsWith(): add unit test for converting to lower case #825
    • CountryServiceImpl.findIdsWhenNameStartsWith(): add unit test for converting to lower case #827
    • SeriesImportServiceImpl.saveParsedData(): add unit tests for michel numbers #902
    • SeriesImportServiceImpl.saveParsedData(): add unit test for seller group #923
    • SeriesSalesImportServiceImpl.downloadAndParse(): add unit tests #1028
    • CollectionService.findSeriesInstances(): add unit tests #1194
    • SeriesImportServiceImpl.saveParsedData(): add unit test for alternative price and currency #1271
    • SeriesServiceImpl.markAsSimilar(): add unit tests #1318
    • ImageServiceImpl.replace(): add unit tests #1366
    • SeriesServiceImpl.replaceImage(): add unit tests #1373
    • SeriesServiceImpl.addReleaseYear(): add unit tests #1423
    • SeriesImportServiceImpl.saveParsedData(): add unit test for condition #1430
    • SeriesServiceImpl.addPrice(): add unit tests #1433
    • SeriesServiceImpl.addCatalogNumbers(): add unit tests #1436
    • CollectionService.findAllForSitemap(): add unit tests #1614
    • CategoryService.findAllForSitemap(): add unit test #1629
    • CountryService.findAllForSitemap(): add unit test #1630
  • find issues created manually
  • close related issues
    • Random.STATUSES: reduce duplication by using EnumSet.allOf() #746
    • Random.participantGroupName(): make the generated names conform to the validation rules #926
• remove comments like protected for using in unit tests