Added error-output as message for seperate-process exception (#45)

* added error-output as message for seperate-process exception

* fixed code-style

Author: wachterjohannes

src/Command/ScheduleTaskCommand.php

@@ -80,16 +80,16 @@ protected function execute(InputInterface $input, OutputInterface $output)
 
         $taskBuilder = $this->scheduler->createTask($handlerClass, $workload);
 
-        if ($cronExpression !== null) {
+        if (null !== $cronExpression) {
             $endDate = null;
-            if ($endDateString !== null) {
+            if (null !== $endDateString) {
                 $endDate = new \DateTime($endDateString);
             }
 
             $taskBuilder->cron($cronExpression, new \DateTime(), $endDate);
         }
 
-        if ($executionDateString !== null) {
+        if (null !== $executionDateString) {
             $taskBuilder->executeAt(new \DateTime($executionDateString));
         }
 

src/DependencyInjection/HandlerCompilerPass.php

@@ -21,6 +21,7 @@
 class HandlerCompilerPass implements CompilerPassInterface
 {
     const REGISTRY_ID = 'task.handler.factory';
+
     const HANDLER_TAG = 'task.handler';
 
     /**

src/Executor/SeparateProcessException.php

@@ -26,6 +26,8 @@ class SeparateProcessException extends \Exception
      */
     public function __construct($errorOutput)
     {
+        parent::__construct($errorOutput);
+
         $this->errorOutput = $errorOutput;
     }
 

src/Executor/SeparateProcessExecutor.php

@@ -131,7 +131,7 @@ private function handle(TaskExecutionInterface $execution)
      */
     private function createException($errorOutput)
     {
-        if (strpos($errorOutput, FailedException::class) !== 0) {
+        if (0 !== strpos($errorOutput, FailedException::class)) {
             return new SeparateProcessException($errorOutput);
         }
 

tests/Functional/Command/ScheduleSystemTasksCommandTest.php

@@ -10,7 +10,7 @@ class ScheduleSystemTasksCommandTest extends BaseCommandTestCase
     public function setUp()
     {
         self::bootKernel();
-        if (self::$kernel->getContainer()->getParameter('kernel.storage') !== 'doctrine') {
+        if ('doctrine' !== self::$kernel->getContainer()->getParameter('kernel.storage')) {
             return $this->markTestSkipped('This testcase will only be called for doctrine storage.');
         }
 

tests/Functional/Entity/TaskRepositoryTest.php

@@ -21,7 +21,7 @@ public function setUp()
 
     public function testFindBySystemKey()
     {
-        if (self::$kernel->getContainer()->getParameter('kernel.storage') !== 'doctrine') {
+        if ('doctrine' !== self::$kernel->getContainer()->getParameter('kernel.storage')) {
             return $this->markTestSkipped('This testcase will only be called for doctrine storage.');
         }
 
@@ -36,7 +36,7 @@ public function testFindBySystemKey()
 
     public function testFindBySystemKeyNotFound()
     {
-        if (self::$kernel->getContainer()->getParameter('kernel.storage') !== 'doctrine') {
+        if ('doctrine' !== self::$kernel->getContainer()->getParameter('kernel.storage')) {
             return $this->markTestSkipped('This testcase will only be called for doctrine storage.');
         }
 
@@ -48,7 +48,7 @@ public function testFindBySystemKeyNotFound()
 
     public function testFindSystemTasks()
     {
-        if (self::$kernel->getContainer()->getParameter('kernel.storage') !== 'doctrine') {
+        if ('doctrine' !== self::$kernel->getContainer()->getParameter('kernel.storage')) {
             return $this->markTestSkipped('This testcase will only be called for doctrine storage.');
         }
 

tests/app/TestKernel.php

@@ -44,7 +44,7 @@ public function registerBundles()
     public function registerContainerConfiguration(LoaderInterface $loader)
     {
         $this->storage = getenv(self::STORAGE_VAR_NAME);
-        if ($this->storage === false) {
+        if (false === $this->storage) {
             $this->storage = 'array';
         }