run code inspection check

Author: inhere

src/CallableResolver.php

@@ -97,7 +97,7 @@ private function resolveCallable($class, $method = '__invoke'): callable
      *
      * @throws \RuntimeException if the callable is not resolvable
      */
-    private function assertCallable($callable)
+    private function assertCallable($callable): void
     {
         if (!\is_callable($callable)) {
             throw new RuntimeException(sprintf(

src/Container.php

@@ -55,7 +55,7 @@ class Container implements ContainerInterface, \ArrayAccess, \IteratorAggregate,
      *       'id' => Service Object
      *       ... ...
      *   ];
-     * @var Service[]
+     * @var ObjectItem[]
      */
     private $services = [];
 
@@ -107,7 +107,7 @@ public function set(string $id, $definition, array $opts = []): self
         // 已经是个服务实例 object
         if (\is_object($definition)) {
             $this->ids[$id] = (bool)$opts['locked'];
-            $this->services[$id] = new Service($definition, $args, $opts['shared'], $opts['locked']);
+            $this->services[$id] = new ObjectItem($definition, $args, $opts['shared'], $opts['locked']);
             $this->setAlias($id, $opts['aliases']);
 
             return $this;
@@ -152,7 +152,7 @@ public function set(string $id, $definition, array $opts = []): self
         }
 
         $this->ids[$id] = (bool)$opts['locked'];
-        $this->services[$id] = new Service($callback, $args, $opts['shared'], $opts['locked']);
+        $this->services[$id] = new ObjectItem($callback, $args, $opts['shared'], $opts['locked']);
         $this->setAlias($id, $opts['aliases']);
 
         // active service
@@ -464,10 +464,10 @@ public function getInstance(string $id, $thrErr = true, $forceNew = false)
      * 获取某一个服务的信息
      * @param      $id
      * @param bool $thrErr
-     * @return Service|null
+     * @return ObjectItem|null
      * @throws \InvalidArgumentException
      */
-    public function getService(string $id, $thrErr = false)
+    public function getService(string $id, $thrErr = false): ?ObjectItem
     {
         $id = $this->resolveAlias($id);
 
@@ -569,9 +569,9 @@ public function isLocked(string $id): bool
     }
 
     /**
-     * 是已注册的服务
+     * Is a registered service object
      * @param string $id
-     * @return bool|Service
+     * @return bool|ObjectItem
      */
     public function has($id)
     {
@@ -591,7 +591,7 @@ public function exists(string $id): bool
 
     /**
      * @param $name
-     * @return bool|Service
+     * @return bool|ObjectItem
      */
     public function __isset($name)
     {
@@ -621,9 +621,9 @@ public function __get($name)
             return $service->get($this);
         }
 
-        $method = 'get' . ucfirst($name);
+        $method = 'get' . \ucfirst($name);
 
-        if (method_exists($this, $method)) {
+        if (\method_exists($this, $method)) {
             return $this->$method();
         }
 
@@ -677,21 +677,20 @@ public function offsetGet($offset)
      * Sets an offset in the iterator.
      * @param   mixed $offset The array offset.
      * @param   mixed $value The array value.
-     * @return $this
      * @throws \InvalidArgumentException
      * @throws DependencyResolutionException
      */
-    public function offsetSet($offset, $value)
+    public function offsetSet($offset, $value): void
     {
-        return $this->set($offset, $value);
+        $this->set($offset, $value);
     }
 
     /**
      * Unset an offset in the iterator.
      * @param   mixed $offset The array offset.
      * @return  void
      */
-    public function offsetUnset($offset)
+    public function offsetUnset($offset): void
     {
         $this->del($offset);
     }

src/DIManager.php

@@ -82,7 +82,7 @@ public static function make(string $name = null, string $group = null): Containe
      * @param string $group
      * @return  void
      */
-    public static function setDefaultGroup($group = 'di')
+    public static function setDefaultGroup($group = 'di'): void
     {
         $group = strtolower(trim($group));
 
@@ -109,7 +109,7 @@ public static function getDefaultGroup(): string
      * reset
      * @param string $group
      */
-    public static function reset($group = null)
+    public static function reset($group = null): void
     {
         if (!$group) {
             static::$containers = [];

src/NameAliasTrait.php

@@ -29,7 +29,7 @@ trait NameAliasTrait
      * @param string       $name
      * @param array|string $alias
      */
-    public function setAlias(string $name, $alias)
+    public function setAlias(string $name, $alias): void
     {
         if (!$name || !$alias) {
             return;

src/Service.php renamed to src/ObjectItem.php

@@ -11,10 +11,10 @@
 namespace Toolkit\DI;
 
 /**
- * Class Service
+ * Class ObjectItem
  * @package Toolkit\DI
  */
-final class Service
+final class ObjectItem
 {
     /**
      * @var callable
@@ -109,7 +109,7 @@ public function getCallback()
     /**
      * @param $callback
      */
-    public function setCallback($callback)
+    public function setCallback($callback): void
     {
         if (!\method_exists($callback, '__invoke')) {
             $this->instance = $callback;
@@ -134,7 +134,7 @@ public function getArguments(): array
      * @param array $params 设置参数
      * @throws \InvalidArgumentException
      */
-    public function setArguments(array $params)
+    public function setArguments(array $params): void
     {
         $this->arguments = $params;
     }
@@ -158,7 +158,7 @@ public function isLocked(): bool
     /**
      * @param bool $locked
      */
-    public function setLocked($locked = true)
+    public function setLocked($locked = true): void
     {
         $this->locked = (bool)$locked;
     }
@@ -174,7 +174,7 @@ public function isShared(): bool
     /**
      * @param bool $shared
      */
-    public function setShared($shared = true)
+    public function setShared($shared = true): void
     {
         $this->shared = (bool)$shared;
     }

test/ContainerTest.php

@@ -18,7 +18,7 @@
  */
 class ContainerTest extends TestCase
 {
-    public function testCreate()
+    public function testCreate(): void
     {
         $di = new Container([
             's1' => SomeClass::class,