wip: improve throwable logging and remove unused error handling methods

Author: g105b

README.md

@@ -85,10 +85,6 @@ The [Github issue tracker][issues] is used to submit bug reports, feature reques
 
 It would be helpful if you could create your issue in the appropriate repository - for instance, if the issue/question is regarding using a database in WebEngine, https://github.com/phpgt/Database/issues would be the best place - but it's fine to create the issue on WebEngine's issue tracker, and someone can then move the issue if necessary.
 
-### Chat to a developer
-
-A hands-on dev chat system is currently being planned
-
 [quick-start]: https://github.com/PhpGt/WebEngine/wiki/Quick-start
 [tutorials]: https://github.com/PhpGt/WebEngine/wiki/hello-world-tutorial
 [contributing]: https://github.com/PhpGt/WebEngine/blob/master/CONTRIBUTING.md

src/Middleware/DefaultServiceLoader.php

@@ -26,7 +26,7 @@ class DefaultServiceLoader {
 	public function __construct(
 		protected Config $config,
 		protected Container $container
-	) {	}
+	) {}
 
 	public function loadResponseHeaders():ResponseHeaders {
 		$response = $this->container->get(Response::class);

src/Middleware/Lifecycle.php

@@ -4,11 +4,9 @@
 use Gt\Config\ConfigFactory;
 use Gt\Config\ConfigSection;
 use Gt\Http\RequestFactory;
-use Gt\Http\Response;
-use Gt\Http\ResponseFactory;
 use Gt\Http\StatusCode;
-use Gt\Http\Stream;
 use Gt\Logger\Log;
+use Gt\Session\Session;
 use Gt\WebEngine\Debug\Timer;
 use Psr\Http\Message\ResponseInterface;
 use Psr\Http\Message\ServerRequestInterface;
@@ -42,7 +40,6 @@
  */
 class Lifecycle implements MiddlewareInterface {
 	private Timer $timer;
-	private Throwable $throwable;
 
 	public function start():void {
 // Before we start, we check if the current URI should be redirected. If it
@@ -97,7 +94,50 @@ public function start():void {
 			$response = $this->process($request, $handler);
 		}
 		catch(Throwable $throwable) {
-			Log::critical($throwable->getMessage(), ["uri" => $request->getUri()] + $request->getHeaders() + $throwable->getTrace()[0]);
+			$ipSesss = $originalGlobals["server"]["REMOTE_ADDR"] . "#" . substr(session_id(), 0, 4);
+			$trace = $throwable->getTrace();
+			$stopTraceAt = null;
+			foreach($trace as $i => $traceItem) {
+				if(str_contains($traceItem["file"] ?? "", "vendor/phpgt/")) {
+					$stopTraceAt = $i;
+					break;
+				}
+
+				$orderedItem = [];
+				foreach(["class", "function", "type", "file", "line"] as $key) {
+					if(isset($traceItem[$key])) {
+						$orderedItem[$key] = $traceItem[$key];
+					}
+				}
+				$trace[$i] = $orderedItem + $traceItem;
+
+				if(str_starts_with($traceItem["file"] ?? "", "gt-logic-stream://")) {
+					$trace[$i]["file"] = substr($traceItem["file"], strlen("gt-logic-stream://"));
+				}
+				if(str_starts_with($traceItem["function"], "Gt\\AppLogic\\")) {
+					$trace[$i]["function"] = substr($traceItem["function"], strlen("Gt\\AppLogic\\"));
+					$trace[$i]["function"] = str_replace("_php\\", ".php\\", $trace[$i]["function"]);
+				}
+			}
+			if($stopTraceAt) {
+				$trace = array_slice($trace, 0, $stopTraceAt);
+			}
+			
+			$cwd = getcwd();
+			$file = $throwable->getFile();
+			if(str_starts_with($file, $cwd)) {
+				$file = substr($file, strlen($cwd));
+				$file = trim($file, "/");
+			}
+
+			Log::critical($throwable->getMessage(), [
+				"session" => $ipSesss,
+				"uri" => $request->getUri(),
+				"file" => $file,
+				"line" => $throwable->getLine(),
+				"trace" => $trace,
+				"body" => file_get_contents("php://input"),
+			]);
 
 			$errorHandler = new ErrorRequestHandler(
 				ConfigFactory::createForProject(
@@ -112,6 +152,7 @@ public function start():void {
 				$originalGlobals["files"],
 				$originalGlobals["server"],
 			);
+
 			$response = $this->process($request, $errorHandler);
 		}
 
@@ -135,21 +176,6 @@ public function process(
 		return $handler->handle($request);
 	}
 
-	public function error(
-		int $errno,
-		string $errstr,
-		?string $errfile = null,
-		?int $errline = null,
-		?array $errcontext = null,
-	):bool {
-		$params = ["error", $errstr];
-		if(isset($this->throwable)) {
-			array_push($params, $this->throwable, get_class($this->throwable));
-		}
-		call_user_func_array($this->debugOutput(...), $params);
-		return true;
-	}
-
 	public function debugOutput(
 		string $name,
 		string $message,
@@ -178,14 +204,6 @@ public function debugOutput(
 		echo $js;
 	}
 
-	public function responseFromThrowable(Throwable $throwable):Response {
-		$response = new Response();
-		$body = new Stream();
-		$body->write("errrrrrrrrrrror!");
-		$response = $response->withBody($body);
-		return $response;
-	}
-
 	public function finish(
 		ResponseInterface $response,
 		ConfigSection $appConfig