Improve BackedEnum::from

Author: VincentLanglet

src/Type/Php/BackedEnumFromDynamicStaticMethodThrowTypeExtension.php

@@ -0,0 +1,60 @@
+<?php declare(strict_types = 1);
+
+namespace PHPStan\Type\Php;
+
+use PhpParser\Node\Expr\MethodCall;
+use PhpParser\Node\Expr\StaticCall;
+use PHPStan\Analyser\Scope;
+use PHPStan\DependencyInjection\AutowiredService;
+use PHPStan\Reflection\MethodReflection;
+use PHPStan\Type\DynamicMethodThrowTypeExtension;
+use PHPStan\Type\DynamicStaticMethodThrowTypeExtension;
+use PHPStan\Type\Type;
+use PHPStan\Type\TypeCombinator;
+use PHPStan\Type\VerbosityLevel;
+use PHPStan\Type\VoidType;
+use function count;
+use function in_array;
+
+#[AutowiredService]
+final class BackedEnumFromDynamicStaticMethodThrowTypeExtension implements DynamicStaticMethodThrowTypeExtension
+{
+
+	public function isStaticMethodSupported(MethodReflection $methodReflection): bool
+	{
+		return $methodReflection->getName() === 'from'
+			&& $methodReflection->getDeclaringClass()->isBackedEnum();
+	}
+
+	public function getThrowTypeFromStaticMethodCall(MethodReflection $methodReflection, StaticCall $methodCall, Scope $scope): ?Type
+	{
+		$arguments = $methodCall->getArgs();
+		if (count($arguments) < 1) {
+			return $methodReflection->getThrowType();
+		}
+
+		$valueType = $scope->getType($arguments[0]->value);
+		if (!$valueType->isConstantScalarValue()->yes()) {
+			return $methodReflection->getThrowType();
+		}
+
+		$enumCases = $methodReflection->getDeclaringClass()->getEnumCases();
+
+		$backingValueTypes = [];
+		foreach ($enumCases as $enumCase) {
+			if ($enumCase->getBackingValueType() === null) {
+				return $methodReflection->getThrowType();
+			}
+
+			$backingValueTypes[] = $enumCase->getBackingValueType();
+		}
+
+		$backingValueType = TypeCombinator::union(...$backingValueTypes);
+		if (!$backingValueType->isSuperTypeOf($valueType)->yes()) {
+			return $methodReflection->getThrowType();
+		}
+
+		return new VoidType();
+	}
+
+}

tests/PHPStan/Rules/Exceptions/MissingCheckedExceptionInMethodThrowsRuleTest.php

@@ -70,4 +70,26 @@ public function testRule(): void
 		$this->analyse([__DIR__ . '/data/missing-exception-method-throws.php'], $errors);
 	}
 
+	public function testBug13297(): void
+	{
+		$this->analyse([__DIR__ . '/data/bug-13297.php'], [
+			[
+				"Method Bug13297\HelloWorld::sayHello3() throws checked exception ValueError but it's missing from the PHPDoc @throws tag.",
+				25,
+			],
+			[
+				"Method Bug13297\HelloWorld::sayHello3() throws checked exception TypeError but it's missing from the PHPDoc @throws tag.",
+				25,
+			],
+			[
+				"Method Bug13297\HelloWorld::sayHello4() throws checked exception ValueError but it's missing from the PHPDoc @throws tag.",
+				31,
+			],
+			[
+				"Method Bug13297\HelloWorld::sayHello4() throws checked exception TypeError but it's missing from the PHPDoc @throws tag.",
+				31,
+			],
+		]);
+	}
+
 }

tests/PHPStan/Rules/Exceptions/data/bug-13297.php

@@ -0,0 +1,33 @@
+<?php declare(strict_types = 1);
+
+namespace Bug13297;
+
+enum Foo: int {
+	case A = 1;
+	case B = 2;
+}
+
+class HelloWorld
+{
+	/** @param value-of<Foo> $int */
+	public function sayHello(int $int): void
+	{
+		Foo::from($int);
+	}
+
+	public function sayHello2(): void
+	{
+		Foo::from(1);
+	}
+
+	public function sayHello3(int $int): void
+	{
+		Foo::from($int);
+	}
+
+	/** @param 1|2|3 $int */
+	public function sayHello4(int $int): void
+	{
+		Foo::from($int);
+	}
+}