Fix SimpleXMLElement::offsetSet

Author: VincentLanglet

stubs/iterable.stub

@@ -99,6 +99,13 @@ class SimpleXMLElement implements Traversable, ArrayAccess, Iterator, RecursiveI
 	 */
 	public function saveXML(?string $filename = null) {  }
 
+	/**
+	 * @param int|string|null $key
+	 * @param self|string|int|float|bool $value
+	 * @return void
+	 */
+	public function offsetSet($key, $value) {}
+
 }
 
 /**

tests/PHPStan/Rules/Arrays/OffsetAccessValueAssignmentRuleTest.php

@@ -63,6 +63,11 @@ public function testRuleWithNullsafeVariant(): void
 		]);
 	}
 
+	public function testBug8236(): void
+	{
+		$this->analyse([__DIR__ . '/data/bug-8236.php'], []);
+	}
+
 	#[RequiresPhp('>= 8.0')]
 	public function testBug5655b(): void
 	{

tests/PHPStan/Rules/Arrays/data/bug-8236.php

@@ -0,0 +1,18 @@
+<?php declare(strict_types = 1);
+
+namespace Bug8236;
+
+class HelloWorld
+{
+	public static function sayHello(): void
+	{
+		$xml = new \SimpleXmlElement('<root><a></a></root>');
+		$string = 'But isn\'t 7 > 5 & 9 < 11?';
+		$node = $xml->a->addChild('formula1');
+		if ($node !== null) {
+			$node[0] = $string;
+		}
+		echo $xml->asXML();
+	}
+}
+HelloWorld::sayHello();