-
Notifications
You must be signed in to change notification settings - Fork 529
Improve implode signature #4159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
8e14c10
to
4e8384f
Compare
This pull request has been marked as ready for review. |
f4a36cb
to
1c8068f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the conflict. It'd probably be the best if you manually check out ParametersAcceptorSelector currently on top of 2.1.x and try to apply your changes in it manually. Because the Git conflict might get hairy.
1c8068f
to
188b089
Compare
Thank you. |
Closes phpstan/phpstan#5760
Closes phpstan/phpstan#12079