Skip to content

Conversation

VincentLanglet
Copy link
Contributor

@VincentLanglet VincentLanglet force-pushed the fix/5760 branch 2 times, most recently from 8e14c10 to 4e8384f Compare July 26, 2025 09:13
@VincentLanglet VincentLanglet requested a review from staabm July 26, 2025 10:11
@VincentLanglet VincentLanglet marked this pull request as ready for review July 26, 2025 10:11
@phpstan-bot
Copy link
Collaborator

This pull request has been marked as ready for review.

Copy link
Member

@ondrejmirtes ondrejmirtes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the conflict. It'd probably be the best if you manually check out ParametersAcceptorSelector currently on top of 2.1.x and try to apply your changes in it manually. Because the Git conflict might get hairy.

@ondrejmirtes ondrejmirtes merged commit e0c4844 into phpstan:2.1.x Sep 2, 2025
450 of 457 checks passed
@ondrejmirtes
Copy link
Member

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect check implode() function for 8.0-8.4 implode/join with null as second argument throws but is not caught by the rule
4 participants