Fix non final object cast to array #4167
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VincentLanglet
force-pushed
the
fix/2730
branch
from
fa843bf to
3ab7c5c
Compare
ondrejmirtes
requested changes
Sep 2, 2025
|
|
||
| $types = [new ArrayType(new MixedType(), new MixedType())]; | ||
| foreach ($arrayKeys as $i => $arrayKey) { | ||
| $types[] = new HasOffsetValueType($arrayKey, $arrayValues[$i]); |
There was a problem hiding this comment.
I'd like to have this limited to a few items, to prevent combinatorial explosion. 16 should be fine.
If there's more, just return plain array type.
There was a problem hiding this comment.
Done with ddfa734
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes phpstan/phpstan#2730