Add more parameterized test cases

Author: mengelbart

bwe_test.go

@@ -67,7 +67,14 @@ func TestMain(m *testing.M) {
 
 func TestBWE(t *testing.T) {
 	networks := map[string]vnetFactory{
-		"constant_capacity": createVirtualNetwork(),
+		"constant_capacity_1mbps_very_low_latency": createVirtualNetwork(1_000_000, 80_000, 50*time.Millisecond),
+		"constant_capacity_5mbps_very_low_latency": createVirtualNetwork(5_000_000, 80_000, 50*time.Millisecond),
+		"constant_capacity_1mbps_low_latency":      createVirtualNetwork(1_000_000, 80_000, 50*time.Millisecond),
+		"constant_capacity_5mbps_low_latency":      createVirtualNetwork(5_000_000, 80_000, 50*time.Millisecond),
+		"constant_capacity_1mbps_medium_latency":   createVirtualNetwork(1_000_000, 80_000, 150*time.Millisecond),
+		"constant_capacity_5mbps_medium_latency":   createVirtualNetwork(5_000_000, 80_000, 150*time.Millisecond),
+		"constant_capacity_1mbps_high_latency":     createVirtualNetwork(1_000_000, 80_000, 300*time.Millisecond),
+		"constant_capacity_5mbps_high_latency":     createVirtualNetwork(5_000_000, 80_000, 300*time.Millisecond),
 	}
 	for name, vnf := range networks {
 		t.Run(name, func(t *testing.T) {
@@ -86,7 +93,6 @@ func TestBWE(t *testing.T) {
 				receiver, err := newPeer(
 					registerDefaultCodecs(),
 					setVNet(network.left, []string{"10.0.1.1"}),
-					registerTWCC(),
 					onRemoteTrack(func(track *webrtc.TrackRemote) {
 						close(onTrack)
 						go func() {
@@ -152,7 +158,7 @@ func TestBWE(t *testing.T) {
 
 				select {
 				case <-onTrack:
-				case <-time.After(time.Second):
+				case <-time.After(5 * time.Second):
 					assert.Fail(t, "on track not called")
 				}
 

go.mod

@@ -7,7 +7,7 @@ require (
 	github.com/pion/logging v0.2.4
 	github.com/pion/rtcp v1.2.16
 	github.com/pion/rtp v1.8.24
-	github.com/pion/transport/v3 v3.0.8
+	github.com/pion/transport/v3 v3.0.9-0.20251018195250-6c2e33524ea2
 	github.com/pion/webrtc/v4 v4.1.4
 	github.com/stretchr/testify v1.11.1
 )
@@ -32,5 +32,3 @@ require (
 	golang.org/x/sys v0.30.0 // indirect
 	gopkg.in/yaml.v3 v3.0.1 // indirect
 )
-
-replace github.com/pion/transport/v3 v3.0.8 => ../transport

go.sum

@@ -32,8 +32,8 @@ github.com/pion/srtp/v3 v3.0.7 h1:QUElw0A/FUg3MP8/KNMZB3i0m8F9XeMnTum86F7S4bs=
 github.com/pion/srtp/v3 v3.0.7/go.mod h1:qvnHeqbhT7kDdB+OGB05KA/P067G3mm7XBfLaLiaNF0=
 github.com/pion/stun/v3 v3.0.0 h1:4h1gwhWLWuZWOJIJR9s2ferRO+W3zA/b6ijOI6mKzUw=
 github.com/pion/stun/v3 v3.0.0/go.mod h1:HvCN8txt8mwi4FBvS3EmDghW6aQJ24T+y+1TKjB5jyU=
-github.com/pion/transport/v3 v3.0.8 h1:oI3myyYnTKUSTthu/NZZ8eu2I5sHbxbUNNFW62olaYc=
-github.com/pion/transport/v3 v3.0.8/go.mod h1:+c2eewC5WJQHiAA46fkMMzoYZSuGzA/7E2FPrOYHctQ=
+github.com/pion/transport/v3 v3.0.9-0.20251018195250-6c2e33524ea2 h1:03XFM07X4ZukGIeIWZ7nfe0LHvqoA3tjG6DDypHugLg=
+github.com/pion/transport/v3 v3.0.9-0.20251018195250-6c2e33524ea2/go.mod h1:+c2eewC5WJQHiAA46fkMMzoYZSuGzA/7E2FPrOYHctQ=
 github.com/pion/turn/v4 v4.1.1 h1:9UnY2HB99tpDyz3cVVZguSxcqkJ1DsTSZ+8TGruh4fc=
 github.com/pion/turn/v4 v4.1.1/go.mod h1:2123tHk1O++vmjI5VSD0awT50NywDAq5A2NNNU4Jjs8=
 github.com/pion/webrtc/v4 v4.1.4 h1:/gK1ACGHXQmtyVVbJFQDxNoODg4eSRiFLB7t9r9pg8M=

peer_test.go

@@ -122,7 +122,7 @@ func registerCCFB() option {
 
 func initGCC(onRateUpdate func(int)) option {
 	return func(p *peer) (err error) {
-		p.estimator, err = gcc.NewSendSideController(1_000_000, 128_000, 5_000_000)
+		p.estimator, err = gcc.NewSendSideController(1_000_000, 128_000, 50_000_000)
 		if err != nil {
 			return err
 		}

virtual_network_test.go

@@ -36,7 +36,7 @@ func (n *virtualNetwork) Close() error {
 	)
 }
 
-func createVirtualNetwork() func(*testing.T) *virtualNetwork {
+func createVirtualNetwork(rate, burst int, delay time.Duration) func(*testing.T) *virtualNetwork {
 	return func(t *testing.T) *virtualNetwork {
 		t.Helper()
 
@@ -58,10 +58,14 @@ func createVirtualNetwork() func(*testing.T) *virtualNetwork {
 		})
 		assert.NoError(t, err)
 
-		leftTBF, err := vnet.NewTokenBucketFilter(leftRouter, vnet.TBFRate(1_000_000), vnet.TBFMaxBurst(80_000))
+		leftTBF, err := vnet.NewTokenBucketFilter(
+			leftRouter,
+			vnet.TBFRate(rate),
+			vnet.TBFMaxBurst(burst),
+		)
 		assert.NoError(t, err)
 
-		leftDelay, err := vnet.NewDelayFilter(leftTBF, 10*time.Millisecond)
+		leftDelay, err := vnet.NewDelayFilter(leftTBF, delay)
 		assert.NoError(t, err)
 
 		err = wan.AddNet(leftDelay)
@@ -82,10 +86,14 @@ func createVirtualNetwork() func(*testing.T) *virtualNetwork {
 		})
 		assert.NoError(t, err)
 
-		rightTBF, err := vnet.NewTokenBucketFilter(rightRouter, vnet.TBFRate(1_000_000), vnet.TBFMaxBurst(80_000))
+		rightTBF, err := vnet.NewTokenBucketFilter(
+			rightRouter,
+			vnet.TBFRate(rate),
+			vnet.TBFMaxBurst(burst),
+		)
 		assert.NoError(t, err)
 
-		rightDelay, err := vnet.NewDelayFilter(rightTBF, 10*time.Millisecond)
+		rightDelay, err := vnet.NewDelayFilter(rightTBF, delay)
 		assert.NoError(t, err)
 
 		err = wan.AddNet(rightDelay)