Skip to content

Commit 784a2ed

Browse files
committed
Disable synctest test on go versions < 1.25
1 parent 5df7726 commit 784a2ed

File tree

5 files changed

+13
-5
lines changed

5 files changed

+13
-5
lines changed

.github/.ci.conf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
# SPDX-FileCopyrightText: 2025 The Pion community <https://pion.ly>
22
# SPDX-License-Identifier: MIT
33

4-
GO_MOD_VERSION_EXPECTED=1.25
4+
GO_MOD_VERSION_EXPECTED=1.24

go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
module github.com/pion/bwe
22

3-
go 1.25
3+
go 1.24
44

55
require (
66
github.com/pion/interceptor v0.1.41-0.20250918133005-ab70b00249ad

simulation/perfect_codec_test.go

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,9 @@ func newPerfectCodec(writer sampleWriter, targetBitrateBps int) *perfectCodec {
5757

5858
// start begins the codec operation, generating frames at the configured frame rate.
5959
func (c *perfectCodec) start() {
60-
c.wg.Go(func() {
60+
c.wg.Add(1)
61+
go func() {
62+
defer c.wg.Done()
6163
msToNextFrame := time.Duration((1.0/float64(c.fps))*1000.0) * time.Millisecond
6264
ticker := time.NewTicker(msToNextFrame)
6365
for {
@@ -84,7 +86,7 @@ func (c *perfectCodec) start() {
8486
return
8587
}
8688
}
87-
})
89+
}()
8890
}
8991

9092
// Close stops the codec and cleans up resources.

simulation/simulation.go

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
// SPDX-FileCopyrightText: 2025 The Pion community <https://pion.ly>
2+
// SPDX-License-Identifier: MIT
3+
4+
// Package simulation implements bandwidth estimation tests using the synctest
5+
// package.
6+
package simulation

simulation/vnet_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
// SPDX-FileCopyrightText: 2025 The Pion community <https://pion.ly>
22
// SPDX-License-Identifier: MIT
33

4-
//go:build !js
4+
//go:build !js && go1.25
55

66
package simulation
77

0 commit comments

Comments
 (0)