Remove RTX codec if no primary

While adding transceivers from SetRemoteDescription,
the filtered codecs could filter out the primart codec
and leave the RTX codec in. Generating an answer with
that fails `SetRemoteDescription` on remote peer due
to an unrecognisable codec. Fix it by filtering out
RTX is primary is not there.

Author: boks1971

peerconnection.go

@@ -1170,6 +1170,7 @@ func (pc *PeerConnection) SetRemoteDescription(desc SessionDescription) error {
 							filteredCodecs = append(filteredCodecs, codec)
 						}
 					}
+
 					_ = transceiver.SetCodecPreferences(filteredCodecs)
 				}
 

rtpcodec.go

@@ -5,6 +5,7 @@ package webrtc
 
 import (
 	"fmt"
+	"strconv"
 	"strings"
 
 	"github.com/pion/webrtc/v4/internal/fmtp"
@@ -155,6 +156,27 @@ func findRTXPayloadType(needle PayloadType, haystack []RTPCodecParameters) Paylo
 	return PayloadType(0)
 }
 
+// Given RTX CodecParameters find the primary CodecParameters if one exists.
+func findPrimaryPayloadTypeForRTX(needle RTPCodecParameters, haystack []RTPCodecParameters) PayloadType {
+	parts := strings.Split(needle.SDPFmtpLine, "=")
+	if len(parts) != 2 || parts[0] != "apt" {
+		return PayloadType(0)
+	}
+
+	primaryPayloadType, err := strconv.Atoi(parts[1])
+	if err != nil || primaryPayloadType < 0 || primaryPayloadType > 255 {
+		return PayloadType(0)
+	}
+
+	for _, c := range haystack {
+		if c.PayloadType == PayloadType(primaryPayloadType) {
+			return c.PayloadType
+		}
+	}
+
+	return PayloadType(0)
+}
+
 // For now, only FlexFEC is supported.
 func findFECPayloadType(haystack []RTPCodecParameters) PayloadType {
 	for _, c := range haystack {

rtpcodec_test.go

@@ -9,6 +9,143 @@ import (
 	"github.com/stretchr/testify/assert"
 )
 
+func TestFindPrimaryPayloadTypeForRTX(t *testing.T) {
+	for _, test := range []struct {
+		Needle            RTPCodecParameters
+		Haystack          []RTPCodecParameters
+		ResultPayloadType PayloadType
+	}{
+		// incorrect fmtp
+		{
+			Needle: RTPCodecParameters{
+				PayloadType: 2,
+				RTPCodecCapability: RTPCodecCapability{
+					MimeType:    MimeTypeRTX,
+					ClockRate:   90000,
+					SDPFmtpLine: "incorrect-fmtp",
+				},
+			},
+			Haystack: []RTPCodecParameters{
+				{
+					PayloadType: 1,
+					RTPCodecCapability: RTPCodecCapability{
+						MimeType:  MimeTypeH264,
+						ClockRate: 90000,
+					},
+				},
+			},
+			ResultPayloadType: 0,
+		},
+		// incomplete fmtp
+		{
+			Needle: RTPCodecParameters{
+				PayloadType: 2,
+				RTPCodecCapability: RTPCodecCapability{
+					MimeType:    MimeTypeRTX,
+					ClockRate:   90000,
+					SDPFmtpLine: "apt=",
+				},
+			},
+			Haystack: []RTPCodecParameters{
+				{
+					PayloadType: 1,
+					RTPCodecCapability: RTPCodecCapability{
+						MimeType:  MimeTypeH264,
+						ClockRate: 90000,
+					},
+				},
+			},
+			ResultPayloadType: 0,
+		},
+		// primary payload type outside range (negative)
+		{
+			Needle: RTPCodecParameters{
+				PayloadType: 2,
+				RTPCodecCapability: RTPCodecCapability{
+					MimeType:    MimeTypeRTX,
+					ClockRate:   90000,
+					SDPFmtpLine: "apt=-10",
+				},
+			},
+			Haystack: []RTPCodecParameters{
+				{
+					PayloadType: 1,
+					RTPCodecCapability: RTPCodecCapability{
+						MimeType:  MimeTypeH264,
+						ClockRate: 90000,
+					},
+				},
+			},
+			ResultPayloadType: 0,
+		},
+		// primary payload type outside range (high positive)
+		{
+			Needle: RTPCodecParameters{
+				PayloadType: 2,
+				RTPCodecCapability: RTPCodecCapability{
+					MimeType:    MimeTypeRTX,
+					ClockRate:   90000,
+					SDPFmtpLine: "apt=1000",
+				},
+			},
+			Haystack: []RTPCodecParameters{
+				{
+					PayloadType: 1,
+					RTPCodecCapability: RTPCodecCapability{
+						MimeType:  MimeTypeH264,
+						ClockRate: 90000,
+					},
+				},
+			},
+			ResultPayloadType: 0,
+		},
+		// non-matching needle
+		{
+			Needle: RTPCodecParameters{
+				PayloadType: 2,
+				RTPCodecCapability: RTPCodecCapability{
+					MimeType:    MimeTypeRTX,
+					ClockRate:   90000,
+					SDPFmtpLine: "apt=23",
+				},
+			},
+			Haystack: []RTPCodecParameters{
+				{
+					PayloadType: 1,
+					RTPCodecCapability: RTPCodecCapability{
+						MimeType:  MimeTypeH264,
+						ClockRate: 90000,
+					},
+				},
+			},
+			ResultPayloadType: 0,
+		},
+		// matching needle
+		{
+			Needle: RTPCodecParameters{
+				PayloadType: 2,
+				RTPCodecCapability: RTPCodecCapability{
+					MimeType:    MimeTypeRTX,
+					ClockRate:   90000,
+					SDPFmtpLine: "apt=1",
+				},
+			},
+			Haystack: []RTPCodecParameters{
+				{
+					PayloadType: 1,
+					RTPCodecCapability: RTPCodecCapability{
+						MimeType:  MimeTypeH264,
+						ClockRate: 90000,
+					},
+				},
+			},
+			ResultPayloadType: 1,
+		},
+	} {
+		assert.Equal(t, test.ResultPayloadType, findPrimaryPayloadTypeForRTX(test.Needle, test.Haystack))
+	}
+}
+
 func TestFindFECPayloadType(t *testing.T) {
 	for _, test := range []struct {
 		Haystack          []RTPCodecParameters

rtptransceiver.go

@@ -8,6 +8,7 @@ package webrtc
 
 import (
 	"fmt"
+	"strings"
 	"sync"
 	"sync/atomic"
 
@@ -60,6 +61,20 @@ func (t *RTPTransceiver) SetCodecPreferences(codecs []RTPCodecParameters) error
 		}
 	}
 
+	// remove RTX codecs if there is no corresponding primary codec
+	for i := len(codecs) - 1; i >= 0; i-- {
+		c := codecs[i]
+		if !strings.EqualFold(c.MimeType, MimeTypeRTX) {
+			continue
+		}
+
+		primaryPayload := findPrimaryPayloadTypeForRTX(c, codecs)
+		if primaryPayload == PayloadType(0) {
+			// no primary for RTX, remove the RTX
+			codecs = append(codecs[:i], codecs[i+1:]...)
+		}
+	}
+
 	t.codecs = codecs
 
 	return nil