Simplify and open dropped tab at the dropped position if possible

Author: piroor

webextensions/background/tree.js

@@ -1761,39 +1761,25 @@ export async function openNewWindowFromTabs(tabs, options = {}) {
     return [];
 
   log('openNewWindowFromTabs: ', tabs, options);
-  const [sourceWindow, sourceScreen] = await Promise.all([
-    browser.windows.get(tabs[0].windowId),
-    SidebarConnection.isOpen(tabs[0].windowId) ?
-      browser.runtime.sendMessage({
-        type:     Constants.kCOMMAND_GET_SCREEN_INFO,
-        windowId: tabs[0].windowId,
-      }) : null,
-  ]);
+  const sourceWindow = await browser.windows.get(tabs[0].windowId);
   const sourceParams = getWindowParamsFromSource(sourceWindow, options);
   const windowParams = {
     //active: true,  // not supported in Firefox...
     url: 'about:blank',
     ...sourceParams,
   };
-  let positioned = (
+  const positioned = (
     'left' in options &&
     'top' in options &&
     // positions are not provided for a maximized or fullscreen window!
     typeof windowParams.left == 'number' &&
     typeof windowParams.top == 'number'
   );
   if (positioned) { // opening new window at the dropped position
-    const leftOffset = Math.min(20, sourceScreen ? Math.max(0, sourceScreen.availWidth - sourceWindow.width) : 20);
-    const topOffset = Math.min(20, sourceScreen ? Math.max(0, sourceScreen.availHeight - sourceWindow.height) : 20);
-    if (leftOffset == 0 && topOffset == 0) {
-      positioned = false;
-    }
-    else {
-      windowParams.left += leftOffset;
-      windowParams.top += topOffset;
-    }
+    windowParams.left = options.left;
+    windowParams.top  = options.top;
   }
-  if (!positioned) {
+  else {
     // We need to delete dimensions here to open new window smartly dimensioned by Firefox itself.
     // See https://github.com/piroor/treestyletab/issues/3959#issuecomment-5494800430
     delete windowParams.height;

webextensions/common/constants.js

@@ -17,7 +17,6 @@ export const kCOMMAND_GET_CONFIG_VALUE               = 'treestyletab:get-config-
 export const kCOMMAND_SET_CONFIG_VALUE               = 'treestyletab:set-config-value';
 export const kCOMMAND_GET_USER_STYLE_RULES           = 'treestyletab:get-user-style-rules';
 export const kCOMMAND_GET_DEVICE_PIXEL_RATIO         = 'treestyletab:get-device-pixel-ratio';
-export const kCOMMAND_GET_SCREEN_INFO                = 'treestyletab:get-screen-info';
 export const kCOMMAND_PULL_TABS                      = 'treestyletab:pull-tabs';
 export const kCOMMAND_SYNC_TABS_ORDER                = 'treestyletab:sync-tabs-order';
 export const kCOMMAND_PULL_TABS_ORDER                = 'treestyletab:pull-tabs-order';

webextensions/sidebar/sidebar.js

@@ -1216,18 +1216,6 @@ function onMessage(message, _sender, _respond) {
     case Constants.kCOMMAND_GET_DEVICE_PIXEL_RATIO:
       return Promise.resolve(window.devicePixelRatio);
 
-    case Constants.kCOMMAND_GET_SCREEN_INFO:
-      return Promise.resolve({
-        availHeight: window.screen.availHeight,
-        availLeft:   window.screen.availLeft,
-        availTop:    window.screen.availTop,
-        availWidth:  window.screen.availWidth,
-        height:      window.screen.height,
-        left:        window.screen.left,
-        top:         window.screen.top,
-        width:       window.screen.width,
-      });
-
     // for automated tests
     case Constants.kCOMMAND_GET_RECT: {
       const firstNode = document.querySelector(message.startBefore || message.selector);