Skip to content

Commit b67f84c

Browse files
committed
Use offset locator for new function for Go 1.24 tracing fixes
Signed-off-by: Dom Del Nano <[email protected]>
1 parent cc165ee commit b67f84c

File tree

2 files changed

+4
-6
lines changed

2 files changed

+4
-6
lines changed

src/stirling/source_connectors/socket_tracer/uprobe_manager.cc

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -895,12 +895,10 @@ int UProbeManager::DeployGoUProbes(const absl::flat_hash_set<md::UPID>& pids) {
895895
go_version = build_info_pair.first;
896896
build_info = std::move(build_info_pair.second);
897897
} else {
898+
VLOG(1) << absl::Substitute("Failed to read build info from binary $0. Message = $1", binary,
899+
build_info_s.status().msg());
900+
898901
continue;
899-
VLOG(1) << absl::Substitute(
900-
"Failed to read build info from binary $0. Likely a Go binary built with an older "
901-
"version of Go without module support (pre 1.12)."
902-
"Message = $1",
903-
binary, build_info_s.status().msg());
904902
}
905903

906904
std::unique_ptr<DwarfReader> dwarf_reader = dwarf_reader_status.ConsumeValueOrDie();

src/stirling/source_connectors/socket_tracer/uprobe_symaddrs.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -347,7 +347,7 @@ Status PopulateHTTP2DebugSymbols(GoOffsetLocator* offset_locator, std::string_vi
347347
"w"));
348348

349349
LOG_ASSIGN_STATUSOR(symaddrs->http2bufferedWriter_conn_offset,
350-
dwarf_reader->GetStructMemberOffset(
350+
offset_locator->GetStructMemberOffset(
351351
"net/http.http2bufferedWriter",
352352
"conn"));
353353
// clang-format on

0 commit comments

Comments
 (0)