Skip to content

Commit fe9852c

Browse files
committed
Address PR feedback
Signed-off-by: Dom Del Nano <[email protected]>
1 parent a840585 commit fe9852c

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

src/stirling/source_connectors/socket_tracer/uprobe_manager.cc

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -895,6 +895,7 @@ int UProbeManager::DeployGoUProbes(const absl::flat_hash_set<md::UPID>& pids) {
895895
go_version = build_info_pair.first;
896896
build_info = std::move(build_info_pair.second);
897897
} else {
898+
continue;
898899
VLOG(1) << absl::Substitute(
899900
"Failed to read build info from binary $0. Likely a Go binary built with an older "
900901
"version of Go without module support (pre 1.12)."
@@ -903,6 +904,9 @@ int UProbeManager::DeployGoUProbes(const absl::flat_hash_set<md::UPID>& pids) {
903904
}
904905

905906
std::unique_ptr<DwarfReader> dwarf_reader = dwarf_reader_status.ConsumeValueOrDie();
907+
908+
// TODO(ddelnano): The struct and function offsets will be populated by the
909+
// next set of changes.
906910
StructOffsetMap struct_offsets;
907911
FunctionArgMap function_offsets;
908912
std::unique_ptr<GoOffsetLocator> offset_locator = std::make_unique<GoOffsetLocator>(

0 commit comments

Comments
 (0)