Skip to content

Fix GolangDwarfReaderTest.FunctionVarLocationConsistency #850

@vihangm

Description

@vihangm

Describe the bug
The GolangDwarfReaderTest.FunctionVarLocationConsistency test only runs a go1.16
binary despite the parametrization suggesting that it works on various versions.
See binary override here

I updated the test to run on binaries compiled with other versions of go and the test fails.
I am unsure if this is a bug and the test setup was an oversight or if this functionality isn't
expected to work beyond go version 1.16

As part of removing go 1.16 from our build toolchain, I am going to update the test to keep
it around and make it parametrize across all versions of go, but disable the test.
We should investigate the test and fix the code/testcase or remove it.

To Reproduce
Steps to reproduce the behavior:

  • Remove the DISABLED_ prefix from FunctionVarLocationConsistency in src/stirling/obj_tools/dwarf_reader_test.cc
  • Run the test

Expected behavior
The test should pass.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions