[Editorial Workflow] | File revision history has confusing/wrong event log of previous file at new revision upload

[touhidurabir]

Valid Title

• I have updated the title to accurately reflect the bug description

Description

After a submission submitted, it is possible to upload a revision of submission file from the editorial workflow section . However the revision log history accessible from the More Information of specific file action menu presents a confusing/wrong log history .

Without any revision upload, the log history is ok and well preserved showing proper entry and download link of the last uploaded file as

However once a new revision is uploaded for that specific file, the new entry still pointing to the previous file instead of the new file that just uploaded as revision . This is confusing (or seems wrong).

What should be the one in this case is that the new log entries should point to the newly upload file not the previous one for which the revision has been uploaded

Steps to Reproduce

1. Login with Editorial role
2. Navigate to workflow dashboard
3. Click on any submission
4. First check the file log history from the file's More Information action menu
5. Now upload a new revision of that file
6. See that the new logs are still pointing to the old file for which revision has been just added, not the one that just uploaded

Expected Result

the revision log history should properly points to the updated files for each actions that been performed .

Actual Result

The revision log history still pointing to the previous file instead of the new file that just uploaded as revision . This is confusing (or seems wrong).

Environment Details

No response

Application Version

OJS/OMP/OPS 3.5/main

Logs

No response

Additional Information

This seems like a very trivial fix where for the event log store, we should passed newly created submission file instance instead of previous one at https://github.com/pkp/pkp-lib/blob/main/classes/submissionFile/Repository.php#L372

PRs

Stable-3.5.0

pkp-lib --> #12350
ojs --> pkp/ojs#5349 [TEST ONLY]
omp --> pkp/omp#2240 [TEST ONLY]
ops --> pkp/ops#1208 [TEST ONLY]

main

pkp-lib --> #12352
ojs --> pkp/ojs#5351 [TEST ONLY]