Enforces delegated access token for onenote commands #7050
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR enforces delegated access tokens for OneNote commands by migrating three commands (onenote page list, onenote notebook list, onenote notebook add) from GraphCommand to GraphDelegatedCommand. This ensures these commands can only be used with delegated (user) permissions and not with application-only permissions.
Key Changes
- Changed base class from
GraphCommandtoGraphDelegatedCommandfor three OneNote commands - Refactored group ID retrieval to use the optimized
entraGroup.getGroupIdByDisplayName()utility method - Added proper encoding for userName parameters using
formatting.encodeQueryParameter() - Added
$select=idquery parameter optimization to minimize data transfer in API calls - Added comprehensive test coverage for delegated permission enforcement
- Updated documentation to explicitly state that application permissions are not supported
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/m365/onenote/commands/page/page-list.ts | Changed to extend GraphDelegatedCommand, added userName encoding, refactored to use entraGroup.getGroupIdByDisplayName() |
| src/m365/onenote/commands/page/page-list.spec.ts | Added accessToken stub setup, new test for delegated permission enforcement, updated test URLs for encoding |
| src/m365/onenote/commands/notebook/notebook-list.ts | Changed to extend GraphDelegatedCommand, added userName encoding, added $select=id optimization |
| src/m365/onenote/commands/notebook/notebook-list.spec.ts | Added accessToken stub setup, new test for delegated permission enforcement, updated test URLs |
| src/m365/onenote/commands/notebook/notebook-add.ts | Changed to extend GraphDelegatedCommand, added userName encoding |
| src/m365/onenote/commands/notebook/notebook-add.spec.ts | Added accessToken stub setup, new test for delegated permission enforcement, updated test URLs |
| docs/docs/cmd/onenote/page/page-list.mdx | Added Permissions section documenting delegated-only support, improved Remarks wording |
| docs/docs/cmd/onenote/notebook/notebook-list.mdx | Added Permissions section documenting delegated-only support |
| docs/docs/cmd/onenote/notebook/notebook-add.mdx | Added Permissions section documenting delegated-only support |
milanholemans
force-pushed
the
update-onenote
branch
from
ef552f6 to
a25d41f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7049