Github gist does not block rendering now

polyrabbit · polyrabbit · commit f4e6d7211145 · 2023-10-05T14:50:47.000+08:00
diff --git a/.github/workflows/static.yml b/.github/workflows/static.yml
@@ -108,7 +108,7 @@ jobs:
           OPENAI_API_KEY: ${{ secrets.OPENAI_API_KEY }}
           DATABASE_URL: ${{ secrets.DATABASE_URL }}
           SYSLOG_ADDRESS: ${{ secrets.SYSLOG_ADDRESS }}
-        if: ${{ endswith(github.run_id, '3') || endswith(github.run_id, '6') || endswith(github.run_id, '9') }}
+        if: ${{ github.event_name == 'push' || endswith(github.run_id, '3') || endswith(github.run_id, '6') || endswith(github.run_id, '9') }}
 
       - name: Generate Home Page
         run: make gh_home_page
diff --git a/page_content_extractor/embeddable.py b/page_content_extractor/embeddable.py
@@ -116,4 +116,6 @@ def gist_github_com_parser(self, url):
         path = urlsplit(url).path
         if path.count('/') < 2:
             raise ParseError('Invalid gist.github.com embeddable url(%s)' % url)
-        return '<script src="https://gist.github.com%s.js"></script>' % path
+        # See https://milanaryal.com.np/how-to-embed-github-gists-in-an-iframe-tag/
+        return f'<iframe src="https://gist.github.com{path}.pibb" style="width: 100%; height: 250px; border: 0;"></iframe>'
+        # return '<script src="https://gist.github.com%s.js"></script>' % path
diff --git a/test/test_embeddable_parser.py b/test/test_embeddable_parser.py
@@ -69,5 +69,5 @@ def test_pdf_yt_parser(self):
     def test_gist_github_com(self):
         parser = EmbeddableExtractor('<html></html>', 'https://gist.github.com/polyrabbit/5693787')
         self.assertEqual(parser.get_content(),
-                         '<script src="https://gist.github.com/polyrabbit/5693787.js"></script>')
+                         '<iframe src="https://gist.github.com/polyrabbit/5693787.pibb" style="width: 100%; height: 250px; border: 0;"></iframe>')
         self.assertRaises(ParseError, EmbeddableExtractor, 'whatever', 'https://gist.github.com/')
