spy detection: cloaked body-block, on-fire silhouette, instant spy-check, area suspicion, death decay

(1) Invisible spy melee check: when bot is stuck (m_fStuckTime>0) with
    no visible enemy, swing melee every 1s to decloak invisible C&D
    spies body-blocking doorways. Previously, cloaked spies were
    completely invisible to stuck detection (isVisible() gate).

(2) On-fire disguised spy: remove teammate-attack prerequisite from
    the flame-silhouette detection branch. A disguised spy on fire is
    now detected purely by their visible fire effect, matching human
    players who see the flame silhouette and immediately know it's a spy.

(3) Instant spy-check: set m_fLastSeeSpyTime to (now - 5s) in foundSpy()
    giving a 5s head start to the search radius. The fPossibleDistance
    calculation starts with a meaningful baseline instead of zero,
    enabling spy-check tasks to fire immediately when a spy is KNOWN.

(4) Area suspicion: m_fSpyAreaSuspicion timer (5-10s) set when a spy
    is discovered. Adds +800u to the spy-check search radius. Also
    spreads via TF_VC_SPY voice command (3-6s timer). Nearby bots
    enter heightened alert state after hearing a spy callout.

(5) Death awareness decay: on death, all spy awareness decays one level
    (KNOWN->SUSPECTED, SUSPECTED->NONE). Combined with m_pPrevSpy
    already being cleared for spy-killers, this gives spies a genuine
    advantage from eliminating their spotters — the respawned bot has
    reduced certainty about who was a spy.

New members: m_fInvisSpyCheckTime, m_fSpyAreaSuspicion (CBotFortress).

3 files, 48 insertions, 3 deletions.

Author: pongo1231

rcbot2/bot_fortress.cpp

@@ -142,6 +142,7 @@ void CBotTF2::hearVoiceCommand(edict_t *pPlayer, byte cmd)
 		{
 			m_vLastSeeSpy = CBotGlobals::entityOrigin(pPlayer);
 			m_fSeeSpyTime = engine->Time() + randomFloat(3.0f, 6.0f);
+			m_fSpyAreaSuspicion = engine->Time() + randomFloat(3.0f, 6.0f);
 			updateCondition(CONDITION_PARANOID);
 			// m_pPrevSpy = pPlayer; // HACK
 		}
@@ -1968,7 +1969,7 @@ void CBotFortress::foundSpy(edict_t *pEdict, TF_Class iDisguise)
 	m_pPrevSpy        = pEdict;
 	m_fSeeSpyTime     = engine->Time() + randomFloat(9.0f, 18.0f);
 	m_vLastSeeSpy     = CBotGlobals::entityOrigin(pEdict);
-	m_fLastSeeSpyTime = engine->Time();
+	m_fLastSeeSpyTime = engine->Time() - 5.0f; // head start for spy-check search radius
 	if (iDisguise && (m_iPrevSpyDisguise != iDisguise))
 		m_iPrevSpyDisguise = iDisguise;
 
@@ -1980,6 +1981,9 @@ void CBotFortress::foundSpy(edict_t *pEdict, TF_Class iDisguise)
 		m_SpyAwareness[iIdx].fWhenBecameKnown     = engine->Time();
 		m_SpyAwareness[iIdx].iSuspectDisguise      = iDisguise;
 	}
+
+	// Area suspicion: heightens paranoia for nearby spy-checking
+	m_fSpyAreaSuspicion = engine->Time() + randomFloat(5.0f, 10.0f);
 };
 
 // got shot by someone
@@ -2121,6 +2125,8 @@ void CBotTF2::spawnInit()
 	m_fLastEurekaTeleport  = 0.0f;
 	m_iBestObscureTeleExit = -1;
 	m_iGuardSlot           = ENTINDEX(m_pEdict) % 4;
+	m_fInvisSpyCheckTime   = 0.0f;
+	m_fSpyAreaSuspicion    = 0.0f;
 
 	m_bIsCarryingTeleExit = false;
 	m_bIsCarryingSentry   = false;
@@ -2775,6 +2781,15 @@ void CBotTF2::died(edict_t *pKiller, const char *pszWeapon)
 {
 	CBotFortress::died(pKiller, pszWeapon);
 
+	// Losing my life means I lose some spy awareness
+	for (int i = 0; i < MAX_PLAYERS; i++)
+	{
+		if (m_SpyAwareness[i].eLevel == SpyAwareness::KNOWN)
+			m_SpyAwareness[i].eLevel = SpyAwareness::SUSPECTED;
+		else if (m_SpyAwareness[i].eLevel == SpyAwareness::SUSPECTED)
+			m_SpyAwareness[i].eLevel = SpyAwareness::NONE;
+	}
+
 	int iWpt = CWaypointLocations::NearestWaypoint(getOrigin(), 256.0f, -1);
 	if (iWpt >= 0)
 	{
@@ -5234,6 +5249,10 @@ void CBotTF2::modThink()
 			if (m_iClass == TF_CLASS_PYRO)
 				fPossibleDistance += 200.0f;
 
+			// Area suspicion: recently spotted a spy or heard a spy callout
+			if (m_fSpyAreaSuspicion > engine->Time())
+				fPossibleDistance += 800.0f;
+
 			if ((m_vLastSeeSpy - getOrigin()).Length() < fPossibleDistance)
 			{
 				updateCondition(CONDITION_PARANOID);
@@ -6719,7 +6738,25 @@ void CBotTF2::checkStuckonSpy(void)
 		}
 	}
 	else
+	{
 		m_fStuckSpyTime = 0.0f;
+
+		// No visible spy found but bot is stuck — may be blocked by cloaked spy
+		if (m_fStuckTime > 0.0f && (!m_pEnemy || !hasSomeConditions(CONDITION_SEE_CUR_ENEMY)))
+		{
+			if (m_fInvisSpyCheckTime < engine->Time())
+			{
+				CBotWeapon *pMelee = getBestWeapon(nullptr, true, true);
+				if (pMelee && pMelee->isMelee() && pMelee->hasWeapon())
+				{
+					if (getCurrentWeapon() != pMelee)
+						select_CWeapon(pMelee->getWeaponInfo());
+					primaryAttack();
+				}
+				m_fInvisSpyCheckTime = engine->Time() + 1.0f;
+			}
+		}
+	}
 }
 
 bool CBotFortress::isClassOnTeam(int iClass, int iTeam)
@@ -14034,8 +14071,8 @@ bool CBotTF2::isEnemy(edict_t *pEdict, bool bCheckWeapons)
 						// be smart - check if player's health is below 0
 						bValid = true;
 					}
-					// if he is on fire and I saw my team mate shoot him within the last 5 seconds, he's a spy!
-					else if (CTeamFortress2Mod::TF2_IsPlayerOnFire(pEdict) && (fSpyAttackTime < 5.0f))
+					// if he is on fire, I can see his flame silhouette — he's a spy!
+					else if (CTeamFortress2Mod::TF2_IsPlayerOnFire(pEdict))
 					{
 						bValid = true;
 					}
@@ -14486,6 +14523,8 @@ CBotTF2::CBotTF2()
 	m_iSpyContext             = 0;
 	memset(m_iSpySeenClassCount, 0, sizeof(m_iSpySeenClassCount));
 	m_pSpyLurkTarget          = MyEHandle(nullptr);
+	m_fInvisSpyCheckTime      = 0.0f;
+	m_fSpyAreaSuspicion       = 0.0f;
 }
 
 void CBotTF2::init(bool bVarInit)

rcbot2/bot_fortress.h

@@ -912,6 +912,11 @@ class CBotFortress : public CBot
 	// List of spies I saw cloak in front of me
 	float m_fSpyLastUncloakedList[MAX_PLAYERS];
 
+	// Timer for invisible-spy melee check when stuck (1s cooldown)
+	float m_fInvisSpyCheckTime;
+	// Area suspicion timer — heightens spy-check paranoia after detection or voice call
+	float m_fSpyAreaSuspicion;
+
 	int m_iTeam;
 
 	float m_fWaitTurnSentry; // amount of time to wait before engineer turns their sentry before building