Skip to content

Commit 62712e9

Browse files
committed
remove waitForPopup
1 parent cd11398 commit 62712e9

File tree

2 files changed

+3
-9
lines changed

2 files changed

+3
-9
lines changed

test/e2e/pages/notebooksPositron.ts

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -218,10 +218,10 @@ export class PositronNotebooks extends Notebooks {
218218
async addCodeToCell(
219219
cellIndex: number,
220220
code: string,
221-
options?: { delay?: number; run?: boolean; waitForSpinner?: boolean; waitForPopup?: boolean }
221+
options?: { delay?: number; run?: boolean; waitForSpinner?: boolean; }
222222
): Promise<Locator> {
223-
const { delay = 0, run = false, waitForSpinner = false, waitForPopup = true } = options ?? {};
224-
return await test.step(`Add code to cell: ${cellIndex}, run: ${run}, waitForSpinner: ${waitForSpinner}, waitForPopup: ${waitForPopup}`, async () => {
223+
const { delay = 0, run = false, waitForSpinner = false } = options ?? {};
224+
return await test.step(`Add code to cell: ${cellIndex}, run: ${run}, waitForSpinner: ${waitForSpinner}`, async () => {
225225
const currentCellCount = await this.getCellCount();
226226

227227
if (cellIndex >= currentCellCount) {
@@ -252,10 +252,6 @@ export class PositronNotebooks extends Notebooks {
252252
});
253253
await expect(spinner).toHaveCount(0, { timeout: DEFAULT_TIMEOUT });
254254
}
255-
256-
if (waitForPopup) {
257-
await expect(this.cellInfoToolTip).toBeVisible();
258-
}
259255
}
260256

261257
return this.cell.nth(cellIndex);

test/e2e/tests/notebook/notebook-focus-and-selection.test.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,6 @@
55

66
import path from 'path';
77
import { test, tags } from '../_test.setup';
8-
import { expect } from '@playwright/test';
9-
import { PositronNotebooks } from '../../pages/notebooksPositron.js';
108

119
test.use({
1210
suiteId: __filename

0 commit comments

Comments
 (0)