From 588697875481d74e04148e6352e778b6bbce58bb Mon Sep 17 00:00:00 2001 From: Davis Vaughan Date: Thu, 12 Jun 2025 11:50:12 -0400 Subject: [PATCH] Stub in an idea that gets R dev help to refresh --- .../positronHelp/browser/positronHelpService.ts | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/src/vs/workbench/contrib/positronHelp/browser/positronHelpService.ts b/src/vs/workbench/contrib/positronHelp/browser/positronHelpService.ts index a9c5d38e3491..a6dca8069332 100644 --- a/src/vs/workbench/contrib/positronHelp/browser/positronHelpService.ts +++ b/src/vs/workbench/contrib/positronHelp/browser/positronHelpService.ts @@ -433,10 +433,13 @@ class PositronHelpService extends Disposable implements IPositronHelpService { * @param helpEntry The help entry to add. */ private addHelpEntry(helpEntry: HelpEntry) { - // If the help entry being added matches the current help entry, don't open it again. - if (this._helpEntries[this._helpEntryIndex]?.sourceUrl === helpEntry.sourceUrl) { - return; - } + // Note: The frontend can't know whether the content underlying the url is fully static or not, + // so the frontend should not be in charge of whether or not we re-request the url content. + // + // // If the help entry being added matches the current help entry, don't open it again. + // if (this._helpEntries[this._helpEntryIndex]?.sourceUrl === helpEntry.sourceUrl) { + // return; + // } // Splice the help entry into the help entries at the current help entry index and trim the // remaining help entries to 10.