Skip to content

Commit 1d2f973

Browse files
committed
refactor current_app_store_version -> version as constructor parameter
1 parent 190c1a9 commit 1d2f973

File tree

1 file changed

+4
-7
lines changed

1 file changed

+4
-7
lines changed

rsconnect/metadata.py

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -406,12 +406,13 @@ class AppStore(DataStore):
406406
are made.
407407
"""
408408

409-
def __init__(self, app_file):
409+
def __init__(self, app_file, version=1):
410410
base_name = str(basename(app_file).rsplit(".", 1)[0]) + ".json"
411411
super(AppStore, self).__init__(
412412
join(dirname(app_file), "rsconnect-python", base_name),
413413
join(config_dirname(), "applications", sha1(abspath(app_file)) + ".json"),
414414
)
415+
self.version = version
415416

416417
def get(self, server_url):
417418
"""
@@ -449,15 +450,15 @@ def set(self, server_url, filename, app_url, app_id, app_guid, title, app_mode):
449450
app_guid=app_guid,
450451
title=title,
451452
app_mode=app_mode.name() if isinstance(app_mode, AppMode) else app_mode,
452-
app_store_version=self.current_app_store_version,
453+
app_store_version=self.version,
453454
),
454455
)
455456

456457
def resolve(self, server, app_id, app_mode):
457458
metadata = self.get(server)
458459
if metadata is None:
459460
logger.debug("No previous deployment to this server was found; this will be a new deployment.")
460-
return app_id, app_mode, self.current_app_store_version
461+
return app_id, app_mode, self.version
461462

462463
logger.debug("Found previous deployment data in %s" % self.get_path())
463464

@@ -471,10 +472,6 @@ def resolve(self, server, app_id, app_mode):
471472
app_store_version = metadata.get("app_store_version")
472473
return app_id, app_mode, app_store_version
473474

474-
@property
475-
def current_app_store_version(self):
476-
return 1
477-
478475

479476
DEFAULT_BUILD_DIR = join(os.getcwd(), "rsconnect-build")
480477

0 commit comments

Comments
 (0)