fix sorting bug

Author: joshyam-k

rsconnect/main.py

@@ -666,6 +666,9 @@ def add(
     set_verbosity(verbose)
     output_params(ctx, locals().items())
 
+    if not name:
+        ctx.fail('--name is required')
+
     validation.validate_connection_options(
         ctx=ctx,
         url=server,

rsconnect/metadata.py

@@ -15,7 +15,16 @@
 from io import BufferedWriter
 from os.path import abspath, basename, dirname, exists, join
 from threading import Lock
-from typing import TYPE_CHECKING, Callable, Dict, Generic, Mapping, Optional, TypeVar, Union
+from typing import (
+    TYPE_CHECKING,
+    Callable,
+    Dict,
+    Generic,
+    Mapping,
+    Optional,
+    TypeVar,
+    Union,
+)
 from urllib.parse import urlparse
 
 # Even though TypedDict is available in Python 3.8, because it's used with NotRequired,
@@ -316,7 +325,7 @@ def get_all_servers(self):
 
         :return: the sorted list of known servers.
         """
-        return self._get_sorted_values(lambda s: s["name"])
+        return self._get_sorted_values(lambda s: s["name"] or "")
 
     def set(
         self,

tests/test_main.py

@@ -1117,6 +1117,30 @@ def test_add_shinyapps_missing_options(self):
             if original_server_value:
                 os.environ["CONNECT_SERVER"] = original_server_value
 
+    def test_add_missing_name(self):
+        """Test that the add command requires --name parameter."""
+        original_api_key_value = os.environ.pop("CONNECT_API_KEY", None)
+        original_server_value = os.environ.pop("CONNECT_SERVER", None)
+        try:
+            runner = CliRunner()
+            result = runner.invoke(
+                cli,
+                [
+                    "add",
+                    "--server",
+                    "https://connect.example.com",
+                    "--api-key",
+                    "test-key",
+                ],
+            )
+            assert result.exit_code != 0, result.output
+            assert "--name is required" in result.output
+        finally:
+            if original_api_key_value:
+                os.environ["CONNECT_API_KEY"] = original_api_key_value
+            if original_server_value:
+                os.environ["CONNECT_SERVER"] = original_server_value
+
     def test_env_management_callback(self):
         ctx = click.Context(cli)