[codex] fix: require fixer commits before resolving comments#232
[codex] fix: require fixer commits before resolving comments#232
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f892cc95bf
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
mrcfps
force-pushed
the
codex/fixer-require-commits-before-resolve
branch
from
f892cc9 to
c03a111
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c03a1114ea
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Preserve the original PR label snapshot during live no-push refreshes and require verified push/reconcile evidence before resolving review comments. Generated-By: looper 0.6.0 (runner=fixer, agent=opencode)
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8591f8aa76
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Generated-By: looper 0.6.0 (runner=fixer, agent=opencode)
1 participant
Summary
Root Cause
Codex fixer runs can stop before editing when
ghcannot reach GitHub from the agent sandbox. The runner still treated the parsed completion as successful, recordedpush.skippedwithno_new_commits, and proceeded to resolve review comments.Validation
go test ./internal/fixergo test ./...