Add option to not show feed loading error messages

prof18 · prof18 · commit 1e774fff3d62 · 2026-01-29T22:49:31.000+01:00
diff --git a/androidApp/src/main/kotlin/com/prof18/feedflow/android/settings/syncstorage/SyncAndStorageScreen.kt b/androidApp/src/main/kotlin/com/prof18/feedflow/android/settings/syncstorage/SyncAndStorageScreen.kt
@@ -21,6 +21,7 @@ fun SyncAndStorageScreen(
         syncPeriod = state.syncPeriod,
         autoDeletePeriod = state.autoDeletePeriod,
         refreshFeedsOnLaunch = state.refreshFeedsOnLaunch,
+        showRssParsingErrors = state.showRssParsingErrors,
         onSyncPeriodSelected = { period ->
             viewModel.updateSyncPeriod(period)
             feedDownloadWorkerEnqueuer.updateWorker(period)
@@ -31,6 +32,9 @@ fun SyncAndStorageScreen(
         onRefreshFeedsOnLaunchToggle = { enabled ->
             viewModel.updateRefreshFeedsOnLaunch(enabled)
         },
+        onShowRssParsingErrorsToggle = { enabled ->
+            viewModel.updateShowRssParsingErrors(enabled)
+        },
         onClearDownloadedArticles = {
             viewModel.clearDownloadedArticleContent()
         },
diff --git a/androidApp/src/main/kotlin/com/prof18/feedflow/android/settings/syncstorage/SyncAndStorageScreenContent.kt b/androidApp/src/main/kotlin/com/prof18/feedflow/android/settings/syncstorage/SyncAndStorageScreenContent.kt
@@ -7,6 +7,7 @@ import androidx.compose.foundation.lazy.LazyColumn
 import androidx.compose.material.icons.Icons
 import androidx.compose.material.icons.automirrored.filled.ArrowBack
 import androidx.compose.material.icons.outlined.DeleteSweep
+import androidx.compose.material.icons.outlined.ErrorOutline
 import androidx.compose.material.icons.outlined.Image
 import androidx.compose.material.icons.outlined.Sync
 import androidx.compose.material3.Icon
@@ -41,10 +42,12 @@ internal fun SyncAndStorageScreenContent(
     syncPeriod: SyncPeriod,
     autoDeletePeriod: AutoDeletePeriod,
     refreshFeedsOnLaunch: Boolean,
+    showRssParsingErrors: Boolean,
     navigateBack: () -> Unit,
     onSyncPeriodSelected: (SyncPeriod) -> Unit,
     onAutoDeletePeriodSelected: (AutoDeletePeriod) -> Unit,
     onRefreshFeedsOnLaunchToggle: (Boolean) -> Unit,
+    onShowRssParsingErrorsToggle: (Boolean) -> Unit,
     onClearDownloadedArticles: () -> Unit,
 ) {
     val context = LocalContext.current
@@ -80,6 +83,15 @@ internal fun SyncAndStorageScreenContent(
                 )
             }
 
+            item {
+                SettingSwitchItem(
+                    title = LocalFeedFlowStrings.current.settingsShowRssParsingErrors,
+                    icon = Icons.Outlined.ErrorOutline,
+                    isChecked = showRssParsingErrors,
+                    onCheckedChange = onShowRssParsingErrorsToggle,
+                )
+            }
+
             item {
                 SyncPeriodSelector(
                     currentPeriod = syncPeriod,
@@ -165,6 +177,8 @@ private fun SyncAndStorageScreenContentPreview() {
             onSyncPeriodSelected = {},
             onAutoDeletePeriodSelected = {},
             onRefreshFeedsOnLaunchToggle = {},
+            showRssParsingErrors = true,
+            onShowRssParsingErrorsToggle = {},
             onClearDownloadedArticles = {},
         )
     }
diff --git a/desktopApp/src/jvmMain/kotlin/com/prof18/feedflow/desktop/home/menubar/BehaviorMenu.kt b/desktopApp/src/jvmMain/kotlin/com/prof18/feedflow/desktop/home/menubar/BehaviorMenu.kt
@@ -51,6 +51,12 @@ internal fun MenuBarScope.BehaviorMenu(
             onCheckedChange = callbacks.onRefreshFeedsOnLaunchToggled,
         )
 
+        CheckboxItem(
+            text = LocalFeedFlowStrings.current.settingsShowRssParsingErrors,
+            checked = settingsState.isShowRssParsingErrorsEnabled,
+            onCheckedChange = callbacks.onShowRssParsingErrorsToggled,
+        )
+
         Separator()
 
         CheckboxItem(
@@ -113,6 +119,7 @@ internal data class BehaviorMenuCallbacks(
     val onSaveReaderModeContentToggled: (Boolean) -> Unit,
     val onPrefetchToggle: (Boolean) -> Unit,
     val onRefreshFeedsOnLaunchToggled: (Boolean) -> Unit,
+    val onShowRssParsingErrorsToggled: (Boolean) -> Unit,
     val onMarkReadWhenScrollingToggled: (Boolean) -> Unit,
     val onReduceMotionToggled: (Boolean) -> Unit,
     val onAutoDeletePeriodSelected: (AutoDeletePeriod) -> Unit,
diff --git a/desktopApp/src/jvmMain/kotlin/com/prof18/feedflow/desktop/home/menubar/MenuBar.kt b/desktopApp/src/jvmMain/kotlin/com/prof18/feedflow/desktop/home/menubar/MenuBar.kt
@@ -86,6 +86,7 @@ fun FrameWindowScope.FeedFlowMenuBar(
             }
         },
         onRefreshFeedsOnLaunchToggled = menuBarViewModel::updateRefreshFeedsOnLaunch,
+        onShowRssParsingErrorsToggled = menuBarViewModel::updateShowRssParsingErrors,
         onMarkReadWhenScrollingToggled = menuBarViewModel::updateMarkReadWhenScrolling,
         onReduceMotionToggled = menuBarViewModel::updateReduceMotionEnabled,
         onAutoDeletePeriodSelected = menuBarViewModel::updateAutoDeletePeriod,
diff --git a/i18n/src/commonMain/resources/locale/values/strings.xml b/i18n/src/commonMain/resources/locale/values/strings.xml
@@ -224,6 +224,7 @@
     <string name="settings_sync_period">Background sync frequency</string>
     <string name="settings_sync_period_desc">Choose how often to check for new articles in the background</string>
     <string name="settings_refresh_feeds_on_launch">Refresh feeds on app start</string>
+    <string name="settings_show_rss_parsing_errors">Show feed loading error messages</string>
     <string name="settings_sync_period_never">Never</string>
     <string name="settings_sync_period_fifteen_minutes">Every 15 minutes</string>
     <string name="settings_sync_period_thirty_minutes">Every 30 minutes</string>
diff --git a/iosApp/Source/Settings/SyncStorage/SyncAndStorageScreen.swift b/iosApp/Source/Settings/SyncStorage/SyncAndStorageScreen.swift
@@ -13,7 +13,8 @@ struct SyncAndStorageScreen: View {
     @State private var settingsState = SyncAndStorageState(
         syncPeriod: .oneHour,
         autoDeletePeriod: .disabled,
-        refreshFeedsOnLaunch: true
+        refreshFeedsOnLaunch: true,
+        showRssParsingErrors: true
     )
 
     var body: some View {
@@ -32,6 +33,10 @@ struct SyncAndStorageScreen: View {
                 get: { settingsState.refreshFeedsOnLaunch },
                 set: { vmStoreOwner.instance.updateRefreshFeedsOnLaunch(enabled: $0) }
             ),
+            showRssParsingErrors: Binding(
+                get: { settingsState.showRssParsingErrors },
+                set: { vmStoreOwner.instance.updateShowRssParsingErrors(enabled: $0) }
+            ),
             onClearDownloadedArticles: {
                 vmStoreOwner.instance.clearDownloadedArticleContent()
             }
diff --git a/iosApp/Source/Settings/SyncStorage/SyncAndStorageScreenContent.swift b/iosApp/Source/Settings/SyncStorage/SyncAndStorageScreenContent.swift
@@ -5,6 +5,7 @@ struct SyncAndStorageScreenContent: View {
     @Binding var syncPeriod: SyncPeriod
     @Binding var autoDeletePeriod: AutoDeletePeriod
     @Binding var refreshFeedsOnLaunch: Bool
+    @Binding var showRssParsingErrors: Bool
     let onClearDownloadedArticles: () -> Void
 
     private let feedFlowStrings = Deps.shared.getStrings()
@@ -16,6 +17,10 @@ struct SyncAndStorageScreenContent: View {
                     Label(feedFlowStrings.settingsRefreshFeedsOnLaunch, systemImage: "arrow.triangle.2.circlepath")
                 }
 
+                Toggle(isOn: $showRssParsingErrors) {
+                    Label(feedFlowStrings.settingsShowRssParsingErrors, systemImage: "exclamationmark.triangle")
+                }
+
                 Picker(selection: $syncPeriod) {
                     Text(feedFlowStrings.settingsSyncPeriodNever)
                         .tag(SyncPeriod.never)
diff --git a/shared/src/commonMain/kotlin/com/prof18/feedflow/shared/data/SettingsRepository.kt b/shared/src/commonMain/kotlin/com/prof18/feedflow/shared/data/SettingsRepository.kt
@@ -135,6 +135,12 @@ class SettingsRepository(
     internal fun setRefreshFeedsOnLaunch(value: Boolean) =
         settings.set(SettingsFields.REFRESH_FEEDS_ON_LAUNCH.name, value)
 
+    fun getShowRssParsingErrors(): Boolean =
+        settings.getBoolean(SettingsFields.SHOW_RSS_PARSING_ERRORS.name, true)
+
+    fun setShowRssParsingErrors(value: Boolean) =
+        settings.set(SettingsFields.SHOW_RSS_PARSING_ERRORS.name, value)
+
     fun getThemeMode(): ThemeMode =
         settings.getString(SettingsFields.THEME_MODE.name, ThemeMode.SYSTEM.name)
             .let { ThemeMode.valueOf(it) }
@@ -179,5 +185,6 @@ private enum class SettingsFields {
     THEME_MODE,
     REDUCE_MOTION_ENABLED,
     REFRESH_FEEDS_ON_LAUNCH,
+    SHOW_RSS_PARSING_ERRORS,
     NOTIFICATION_MODE,
 }
diff --git a/shared/src/commonMain/kotlin/com/prof18/feedflow/shared/domain/feed/FeedFetcherRepository.kt b/shared/src/commonMain/kotlin/com/prof18/feedflow/shared/domain/feed/FeedFetcherRepository.kt
@@ -243,6 +243,7 @@ class FeedFetcherRepository internal constructor(
         forceRefresh: Boolean,
     ) {
         val allFeedItems = mutableListOf<FeedItem>()
+        val shouldShowParsingErrors = settingsRepository.getShowRssParsingErrors()
 
         feedSourceUrls
             .mapNotNull { feedSource ->
@@ -287,11 +288,13 @@ class FeedFetcherRepository internal constructor(
                         }
                         // Mark failure flag on error
                         databaseHelper.setFeedFetchFailed(feedSource.id, true)
-                        feedStateRepository.emitErrorState(
-                            FeedErrorState(
-                                failingSourceName = feedSource.title,
-                            ),
-                        )
+                        if (shouldShowParsingErrors) {
+                            feedStateRepository.emitErrorState(
+                                FeedErrorState(
+                                    failingSourceName = feedSource.title,
+                                ),
+                            )
+                        }
                         feedToUpdate.remove(feedSource.url)
                         updateRefreshCount()
                         null
diff --git a/shared/src/commonMain/kotlin/com/prof18/feedflow/shared/presentation/MenuBarViewModel.kt b/shared/src/commonMain/kotlin/com/prof18/feedflow/shared/presentation/MenuBarViewModel.kt
@@ -40,6 +40,7 @@ class MenuBarViewModel internal constructor(
         val isSaveReaderModeContentEnabled = settingsRepository.isSaveItemContentOnOpenEnabled()
         val isPrefetchArticleContentEnabled = settingsRepository.isPrefetchArticleContentEnabled()
         val isRefreshFeedsOnLaunchEnabled = settingsRepository.getRefreshFeedsOnLaunch()
+        val isShowRssParsingErrorsEnabled = settingsRepository.getShowRssParsingErrors()
         val isReduceMotionEnabled = settingsRepository.getReduceMotionEnabled()
         val autoDeletePeriod = settingsRepository.getAutoDeletePeriod()
         val isCrashReportingEnabled = settingsRepository.getCrashReportingEnabled()
@@ -54,6 +55,7 @@ class MenuBarViewModel internal constructor(
                 isSaveReaderModeContentEnabled = isSaveReaderModeContentEnabled,
                 isPrefetchArticleContentEnabled = isPrefetchArticleContentEnabled,
                 isRefreshFeedsOnLaunchEnabled = isRefreshFeedsOnLaunchEnabled,
+                isShowRssParsingErrorsEnabled = isShowRssParsingErrorsEnabled,
                 isReduceMotionEnabled = isReduceMotionEnabled,
                 autoDeletePeriod = autoDeletePeriod,
                 isCrashReportingEnabled = isCrashReportingEnabled,
@@ -128,6 +130,15 @@ class MenuBarViewModel internal constructor(
         }
     }
 
+    fun updateShowRssParsingErrors(value: Boolean) {
+        viewModelScope.launch {
+            settingsRepository.setShowRssParsingErrors(value)
+            stateMutableFlow.update {
+                it.copy(isShowRssParsingErrorsEnabled = value)
+            }
+        }
+    }
+
     fun updateReduceMotionEnabled(value: Boolean) {
         viewModelScope.launch {
             settingsRepository.setReduceMotionEnabled(value)
diff --git a/shared/src/commonMain/kotlin/com/prof18/feedflow/shared/presentation/SyncAndStorageSettingsViewModel.kt b/shared/src/commonMain/kotlin/com/prof18/feedflow/shared/presentation/SyncAndStorageSettingsViewModel.kt
@@ -32,12 +32,14 @@ class SyncAndStorageSettingsViewModel internal constructor(
     private fun loadSettings(syncPeriod: SyncPeriod) {
         val autoDeletePeriod = settingsRepository.getAutoDeletePeriod()
         val refreshFeedsOnLaunch = settingsRepository.getRefreshFeedsOnLaunch()
+        val showRssParsingErrors = settingsRepository.getShowRssParsingErrors()
 
         stateMutableFlow.update {
             SyncAndStorageState(
                 syncPeriod = syncPeriod,
                 autoDeletePeriod = autoDeletePeriod,
                 refreshFeedsOnLaunch = refreshFeedsOnLaunch,
+                showRssParsingErrors = showRssParsingErrors,
             )
         }
     }
@@ -69,6 +71,15 @@ class SyncAndStorageSettingsViewModel internal constructor(
         }
     }
 
+    fun updateShowRssParsingErrors(enabled: Boolean) {
+        viewModelScope.launch {
+            settingsRepository.setShowRssParsingErrors(enabled)
+            stateMutableFlow.update {
+                it.copy(showRssParsingErrors = enabled)
+            }
+        }
+    }
+
     fun clearDownloadedArticleContent() {
         viewModelScope.launch {
             feedItemContentFileHandler.clearAllContent()
diff --git a/shared/src/commonMain/kotlin/com/prof18/feedflow/shared/presentation/model/MenuBarSettingsState.kt b/shared/src/commonMain/kotlin/com/prof18/feedflow/shared/presentation/model/MenuBarSettingsState.kt
@@ -12,6 +12,7 @@ data class MenuBarSettingsState(
     val isSaveReaderModeContentEnabled: Boolean = false,
     val isPrefetchArticleContentEnabled: Boolean = false,
     val isRefreshFeedsOnLaunchEnabled: Boolean = true,
+    val isShowRssParsingErrorsEnabled: Boolean = true,
     val isReduceMotionEnabled: Boolean = false,
     val autoDeletePeriod: AutoDeletePeriod = AutoDeletePeriod.DISABLED,
     val isCrashReportingEnabled: Boolean = true,
diff --git a/shared/src/commonMain/kotlin/com/prof18/feedflow/shared/presentation/model/SyncAndStorageState.kt b/shared/src/commonMain/kotlin/com/prof18/feedflow/shared/presentation/model/SyncAndStorageState.kt
@@ -7,4 +7,5 @@ data class SyncAndStorageState(
     val syncPeriod: SyncPeriod = SyncPeriod.ONE_HOUR,
     val autoDeletePeriod: AutoDeletePeriod = AutoDeletePeriod.DISABLED,
     val refreshFeedsOnLaunch: Boolean = true,
+    val showRssParsingErrors: Boolean = true,
 )
diff --git a/shared/src/commonTest/kotlin/com/prof18/feedflow/shared/domain/feed/FeedFetcherRepositoryLocalTest.kt b/shared/src/commonTest/kotlin/com/prof18/feedflow/shared/domain/feed/FeedFetcherRepositoryLocalTest.kt
@@ -310,6 +310,31 @@ class FeedFetcherRepositoryLocalTest : FeedFetcherRepositoryTestBase() {
         assertTrue(updatedFeedSource.fetchFailed)
     }
 
+    @Test
+    fun `fetchFeeds marks feed as failed without emitting error when parsing errors are hidden`() =
+        runTest(testDispatcher) {
+            setupLocalAccount()
+            settingsRepository.setShowRssParsingErrors(false)
+
+            val feedSource = createFeedSource(
+                id = "source-1",
+                title = "Broken Feed",
+            )
+            databaseHelper.insertFeedSource(listOf(feedSource.toParsedFeedSource()))
+            fakeRssParserWrapper.setError(feedSource.url)
+
+            feedStateRepository.errorState.test {
+                feedFetcherRepository.fetchFeeds()
+                advanceUntilIdle()
+
+                expectNoEvents()
+            }
+
+            val updatedFeedSource = databaseHelper.getFeedSource(feedSource.id)
+            assertNotNull(updatedFeedSource)
+            assertTrue(updatedFeedSource.fetchFailed)
+        }
+
     @Test
     fun `fetchFeeds cleans old items when auto delete is enabled`() = runTest(testDispatcher) {
         setupLocalAccount()
diff --git a/shared/src/commonTest/kotlin/com/prof18/feedflow/shared/presentation/MenuBarViewModelTest.kt b/shared/src/commonTest/kotlin/com/prof18/feedflow/shared/presentation/MenuBarViewModelTest.kt
@@ -39,6 +39,7 @@ class MenuBarViewModelTest : KoinTestBase() {
         assertFalse(state.isSaveReaderModeContentEnabled)
         assertFalse(state.isPrefetchArticleContentEnabled)
         assertTrue(state.isRefreshFeedsOnLaunchEnabled)
+        assertTrue(state.isShowRssParsingErrorsEnabled)
         assertFalse(state.isReduceMotionEnabled)
         assertEquals(AutoDeletePeriod.DISABLED, state.autoDeletePeriod)
         assertTrue(state.isCrashReportingEnabled)
@@ -99,6 +100,12 @@ class MenuBarViewModelTest : KoinTestBase() {
         assertFalse(viewModel.state.value.isRefreshFeedsOnLaunchEnabled)
     }
 
+    @Test
+    fun `updateShowRssParsingErrors updates state`() = runTest {
+        viewModel.updateShowRssParsingErrors(false)
+        assertFalse(viewModel.state.value.isShowRssParsingErrorsEnabled)
+    }
+
     @Test
     fun `updateReduceMotionEnabled updates state`() = runTest {
         viewModel.updateReduceMotionEnabled(true)
diff --git a/shared/src/commonTest/kotlin/com/prof18/feedflow/shared/presentation/SyncAndStorageSettingsViewModelTest.kt b/shared/src/commonTest/kotlin/com/prof18/feedflow/shared/presentation/SyncAndStorageSettingsViewModelTest.kt
@@ -24,6 +24,7 @@ class SyncAndStorageSettingsViewModelTest : KoinTestBase() {
             assertEquals(SyncPeriod.NEVER, initialState.syncPeriod)
             assertEquals(AutoDeletePeriod.DISABLED, initialState.autoDeletePeriod)
             assertTrue(initialState.refreshFeedsOnLaunch)
+            assertTrue(initialState.showRssParsingErrors)
         }
     }
 
@@ -64,6 +65,19 @@ class SyncAndStorageSettingsViewModelTest : KoinTestBase() {
         }
     }
 
+    @Test
+    fun `updateShowRssParsingErrors updates state`() = runTest {
+        viewModel.state.test {
+            awaitItem()
+
+            viewModel.updateShowRssParsingErrors(false)
+            assertFalse(awaitItem().showRssParsingErrors)
+
+            viewModel.updateShowRssParsingErrors(true)
+            assertTrue(awaitItem().showRssParsingErrors)
+        }
+    }
+
     @Test
     fun `clearDownloadedArticleContent clears saved content`() = runTest {
         val feedItemId = "item-id"

Original file line number	Diff line number	Diff line change
`@@ -86,6 +86,7 @@ fun FrameWindowScope.FeedFlowMenuBar(`
`86`	`86`	`}`
`87`	`87`	`},`
`88`	`88`	`onRefreshFeedsOnLaunchToggled = menuBarViewModel::updateRefreshFeedsOnLaunch,`
	`89`	`+ onShowRssParsingErrorsToggled = menuBarViewModel::updateShowRssParsingErrors,`
`89`	`90`	`onMarkReadWhenScrollingToggled = menuBarViewModel::updateMarkReadWhenScrolling,`
`90`	`91`	`onReduceMotionToggled = menuBarViewModel::updateReduceMotionEnabled,`
`91`	`92`	`onAutoDeletePeriodSelected = menuBarViewModel::updateAutoDeletePeriod,`