Skip to content

Commit b7a28d3

Browse files
Merge branch 'project-chip:master' into CommandTesting
2 parents f142329 + 7e83b9f commit b7a28d3

File tree

7 files changed

+17
-25
lines changed

7 files changed

+17
-25
lines changed

.github/actions/setup-ccache/action.yml

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,15 +24,13 @@ runs:
2424
steps:
2525
- name: Configure ccache
2626
uses: pyTooling/Actions/[email protected]
27-
# NOTE: the following was REMOVED because it causes invalid cache re-uses.
28-
# We observed changed headers not being detected in cpp file rebuilds and
29-
# caches being re-used when they should not be.
30-
# echo "CCACHE_PREFIX_CPP=${{ github.workspace }}/scripts/helpers/ccache-prefix-cpp.sh" >> $GITHUB_ENV
3127
with:
3228
main: |
3329
mkdir -p .ccache
3430
echo "CCACHE_NOHASHDIR=1" >> $GITHUB_ENV
3531
echo "CCACHE_BASEDIR=${{ github.workspace }}" >> $GITHUB_ENV
32+
echo "CCACHE_NODIRECT=1" >> $GITHUB_ENV
33+
echo "CCACHE_PREFIX_CPP=${{ github.workspace }}/scripts/helpers/ccache-prefix-cpp.sh" >> $GITHUB_ENV
3634
echo "CCACHE_SLOPPINESS=time_macros" >> $GITHUB_ENV
3735
echo "CCACHE_DIR=${{ github.workspace }}/.ccache" >> $GITHUB_ENV
3836
echo "CCACHE_COMPILERCHECK=content" >> $GITHUB_ENV

.github/workflows/examples-linux-arm.yaml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -27,10 +27,6 @@ concurrency:
2727
cancel-in-progress: true
2828

2929
env:
30-
CCACHE_NOHASHDIR: 1
31-
CCACHE_BASEDIR: ${{ github.workspace }}
32-
# Disabled as this seems to cause invalid cache re-uses
33-
# CCACHE_PREFIX_CPP: ${{ github.workspace }}/scripts/helpers/ccache-prefix-cpp.sh
3430
CHIP_NO_LOG_TIMESTAMPS: true
3531
CHIP_PW_COMMAND_LAUNCHER: ccache
3632

.github/workflows/examples-linux-standalone.yaml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -27,10 +27,6 @@ concurrency:
2727
cancel-in-progress: true
2828

2929
env:
30-
CCACHE_NOHASHDIR: 1
31-
CCACHE_BASEDIR: ${{ github.workspace }}
32-
# Disabled as this seems to cause invalid cache re-uses
33-
# CCACHE_PREFIX_CPP: ${{ github.workspace }}/scripts/helpers/ccache-prefix-cpp.sh
3430
CHIP_NO_LOG_TIMESTAMPS: true
3531
CHIP_PW_COMMAND_LAUNCHER: ccache
3632

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
173 : [Espressif] Update IDF version to v5.5.1
1+
174 : [Telink] Update Docker image (Zephyr update)

integrations/docker/images/stage-2/chip-build-telink-zephyr_3_3/Dockerfile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,8 @@ RUN set -x \
1818
&& : # last line
1919

2020
# Setup Zephyr version: 3.3.0; branch: develop_3.3
21-
ARG ZEPHYR_REVISION=f8e451335378fe5005679586eb57b64960f7e607
22-
ARG N22_BIN_REVISION=d8fcfa278c320ac2a330e6488a308b704887977a
21+
ARG ZEPHYR_REVISION=db1c965219cb9bac28b059b4f4a1c0f349b446cf
22+
ARG N22_BIN_REVISION=0274673a35327d2c822739fdc622f55fb226ffc8
2323
WORKDIR /opt/telink/zephyrproject
2424
RUN set -x \
2525
&& python3 -m pip install --break-system-packages -U --no-cache-dir west \

integrations/docker/images/stage-2/chip-build-telink/Dockerfile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,8 @@ RUN set -x \
1818
&& : # last line
1919

2020
# Setup Zephyr version: 4.1.0; branch: develop
21-
ARG ZEPHYR_REVISION=1ce482a5d8846343af3f411532521677339a3630
22-
ARG N22_BIN_REVISION=d8fcfa278c320ac2a330e6488a308b704887977a
21+
ARG ZEPHYR_REVISION=f88abc25ab51a6e1bafaea05e57f7ca01bdec7be
22+
ARG N22_BIN_REVISION=0274673a35327d2c822739fdc622f55fb226ffc8
2323
WORKDIR /opt/telink/zephyrproject
2424
RUN set -x \
2525
&& python3 -m pip install --break-system-packages -U --no-cache-dir west \

scripts/setup/bootstrap.sh

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -205,14 +205,16 @@ if [ -n "$ZSH_VERSION" ]; then
205205
fi
206206

207207
# Set ccache environment variables
208-
# TODO: For now, the ccache env is not enabled globally, however, anyone can
209-
# enable it in the local environment, so apps build in different output
210-
# directories can reuse cache. In order to enable it globally we need
211-
# to figure out why NRF builds do not work when sharing cache between
212-
# applications.
213-
#export CCACHE_NOHASHDIR=1
214-
#export CCACHE_BASEDIR="$_CHIP_ROOT"
215-
#export CCACHE_PREFIX_CPP="$_CHIP_ROOT/scripts/helpers/ccache-prefix-cpp.sh"
208+
#
209+
# Rewrite includes to use relative paths within BASEDIR and do not add PWD to
210+
# the hash key, so we can share cached objects even though apps are built in
211+
# different output directories.
212+
export CCACHE_BASEDIR="$_CHIP_ROOT" CCACHE_NOHASHDIR=1
213+
# Always create cache key based on preprocessed source. It is important, because
214+
# we want to reuse cached objects across different apps and configurations.
215+
export CCACHE_NODIRECT=1
216+
# Wrap preprocessor with our script to allow some tweaking.
217+
export CCACHE_PREFIX_CPP="$_CHIP_ROOT/scripts/helpers/ccache-prefix-cpp.sh"
216218

217219
unset -f _bootstrap_or_activate
218220
unset -f _install_additional_pip_requirements

0 commit comments

Comments
 (0)