[Silabs] Closure State LCD implementation #41521
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR #41521: Size comparison from c87ece5 to 9d933e2 Full report (37 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
src/app/clusters/closure-control-server/closure-control-cluster-matter-context.h
Show resolved
Hide resolved
jepenven-silabs
requested changes
Nov 4, 2025
Contributor
jepenven-silabs
left a comment
jepenven-silabs
left a comment
There was a problem hiding this comment.
Looks like not all comments were not resolve and I found code that shouldn't compile with the default Matter compiler option... 🤔 Stopping review for now
Contributor
Author
|
|
PR #41521: Size comparison from 18b2ec9 to 1c39529 Full report (35 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
|
PR #41521: Size comparison from 5ce4e4d to 6ed893d Full report (35 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
|
PR #41521: Size comparison from 55a0ef5 to d83f0e5 Full report (35 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
|
PR #41521: Size comparison from 55a0ef5 to 6527a9b Full report (35 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
AliTalebVelux
approved these changes
Nov 7, 2025
|
PR #41521: Size comparison from 55a0ef5 to 4680598 Full report (35 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
|
PR #41521: Size comparison from 55a0ef5 to 701c807 Full report (35 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
jepenven-silabs
approved these changes
Nov 7, 2025
bhmanda-silabs
pushed a commit
to bhmanda-silabs/connectedhomeip
that referenced
this pull request
Nov 14, 2025
* closure LCD UI * Add attribute reporting updates * PR comments * PR comments * Restyled by whitespace * Restyled by clang-format * PR Comments * Addressing PR comments and reducing code bloats * remove non platfrom changes * Restyled by whitespace * Restyled by clang-format * PR comments * PR comments * PR comments * Restyled by clang-format * PR comments --------- Co-authored-by: Restyled.io <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a comprehensive LCD user interface for the Closure Control
application on Silicon Labs platforms. The UI displays real-time closure state
information including main state, position, latch status, secure status, and
speed, with automatic updates based on Matter attribute changes.
1. New UI Components
Matter)
2. String Management
management
3. Integration Points
attribute reporting
4. UI Display Elements
Technical Details
Architecture
Related issues
Testing
Tested on 917SoC to see the closure state on LCD , and Closure state displayed on LCD updates with attribute updates
Readability checklist
The checklist below will help the reviewer finish PR review in time and keep the
code readable:
descriptive
“When in Rome…”
rule (coding style)
See: Pull Request Guidelines