Skip to content

Commit 955d9ee

Browse files
committed
Add temp file cleanup in config_test.go
Signed-off-by: pincher95 <[email protected]>
1 parent 9ca4648 commit 955d9ee

File tree

1 file changed

+10
-5
lines changed

1 file changed

+10
-5
lines changed

config/config_test.go

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,10 @@ func mustTempFile(t *testing.T) string {
1111
t.Fatalf("temp file: %v", err)
1212
}
1313
f.Close()
14-
return f.Name()
14+
// Ensure temp file is removed even if created outside of test's TempDir semantics change
15+
path := f.Name()
16+
t.Cleanup(func() { _ = os.Remove(path) })
17+
return path
1518
}
1619

1720
// ---------------------------- Positive cases ----------------------------
@@ -80,8 +83,9 @@ func TestLoadConfigPositiveVariants(t *testing.T) {
8083

8184
for _, c := range positive {
8285
tmp, _ := os.CreateTemp(t.TempDir(), "cfg-*.yml")
83-
tmp.WriteString(c.yaml)
84-
tmp.Close()
86+
_, _ = tmp.WriteString(c.yaml)
87+
_ = tmp.Close()
88+
t.Cleanup(func() { _ = os.Remove(tmp.Name()) })
8589
if _, err := LoadConfig(tmp.Name()); err != nil {
8690
t.Fatalf("%s: expected success, got %v", c.name, err)
8791
}
@@ -156,8 +160,9 @@ func TestLoadConfigNegativeVariants(t *testing.T) {
156160

157161
for _, c := range negative {
158162
tmp, _ := os.CreateTemp(t.TempDir(), "cfg-*.yml")
159-
tmp.WriteString(c.yaml)
160-
tmp.Close()
163+
_, _ = tmp.WriteString(c.yaml)
164+
_ = tmp.Close()
165+
t.Cleanup(func() { _ = os.Remove(tmp.Name()) })
161166
if _, err := LoadConfig(tmp.Name()); err == nil {
162167
t.Fatalf("%s: expected validation error, got none", c.name)
163168
}

0 commit comments

Comments
 (0)