feat: add node label on elasticsearch_nodes_roles metric #1107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pincher95
changed the title
Contributor
Author
|
resolve #1105 |
Contributor
|
This PR description seems to be inaccurate. Please update the description with the accurate description of the intent of this PR. |
Contributor
Author
|
@sysadmind updated |
Contributor
|
I think this content is okay, but the commit history is a mess. I think this needs to be rebased onto the latest master branch. |
pincher95
force-pushed
the
feature/add-node-label-to-nodes-roles
branch
2 times, most recently
from
8a1f65d to
625f38e
Compare
pincher95
force-pushed
the
feature/add-node-label-to-nodes-roles
branch
from
625f38e to
279ba21
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the
elasticsearch_nodes_rolesmetric to include the node ID as a new label, improving the uniqueness and traceability of reported node roles. The change modifies both the metric collection logic and the related tests to ensure the new label is present and validated.Enhancements to Node Role Metrics:
node(node ID) label to theelasticsearch_nodes_rolesmetric definition, making each metric instance uniquely identifiable by node ID in addition to cluster, host, and name.collector/nodes.goto iterate over node IDs and include the node ID as a label value when emitting node role metrics. [1] [2]Test Updates:
collector/nodes_test.goto require the newnodelabel in allelasticsearch_nodes_rolesmetric assertions, ensuring tests validate the updated metric format. [1] [2] [3]