java's method Double.toString is able to convert not-a-number values to "NaN" string (#611)

turbanoff · web-flow · commit 683466fcf100 · 2021-01-03T17:53:32.000Z
Signed-off-by: Andrey Turbanov &lt;turbanoff@gmail.com&gt;
diff --git a/simpleclient/src/main/java/io/prometheus/client/Collector.java b/simpleclient/src/main/java/io/prometheus/client/Collector.java
@@ -88,7 +88,7 @@ public Sample(String name, List<String> labelNames, List<String> labelValues, do
       }
 
       public Sample(String name, List<String> labelNames, List<String> labelValues, double value) {
-    	  this(name, labelNames, labelValues, value, null);
+        this(name, labelNames, labelValues, value, null);
       }
 
       @Override
@@ -217,9 +217,6 @@ public static String doubleToGoString(double d) {
     if (d == Double.NEGATIVE_INFINITY) {
       return "-Inf";
     }
-    if (Double.isNaN(d)) {
-      return "NaN";
-    }
     return Double.toString(d);
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -88,7 +88,7 @@ public Sample(String name, List<String> labelNames, List<String> labelValues, do`
`88`	`88`	`}`
`89`	`89`
`90`	`90`	`public Sample(String name, List<String> labelNames, List<String> labelValues, double value) {`
`91`		`- this(name, labelNames, labelValues, value, null);`
	`91`	`+ this(name, labelNames, labelValues, value, null);`
`92`	`92`	`}`
`93`	`93`
`94`	`94`	`@Override`
`@@ -217,9 +217,6 @@ public static String doubleToGoString(double d) {`
`217`	`217`	`if (d == Double.NEGATIVE_INFINITY) {`
`218`	`218`	`return "-Inf";`
`219`	`219`	`}`
`220`		`- if (Double.isNaN(d)) {`
`221`		`- return "NaN";`
`222`		`- }`
`223`	`220`	`return Double.toString(d);`
`224`	`221`	`}`
`225`	`222`	`}`