Conversation
roidelapluie
reviewed
Apr 8, 2026
roidelapluie
reviewed
Apr 8, 2026
| publish_main: | ||
| name: Publish main branch artifacts | ||
| runs-on: ubuntu-latest | ||
| needs: [test_go, build] |
Member
There was a problem hiding this comment.
also intergration, mixin ?
Member
Author
There was a problem hiding this comment.
Integration yes, but we don't publish the mixins.
Member
|
we should support a custom DSN -- changes are needed in tests. I would also run integration tests with -v. We could also have health checks in the service section. |
| image: ${{ matrix.mysql_image }} | ||
| env: | ||
| MYSQL_ALLOW_EMPTY_PASSWORD: "yes" | ||
| MYSQL_ROOT_HOST: '%' |
Member
There was a problem hiding this comment.
options: >-
--health-cmd="mysqladmin ping"
--health-interval=10s
--health-timeout=5s
--health-retries=10
Member
Author
|
So, I have a suspicion that the integration test doesn't actually do anything. I have no running mysql locally and nothing fails. :-/ |
Member
|
We would need to set a dynamic DSN in the github workflow Then change some go code: diff --git a/collector/exporter_test.go b/collector/exporter_test.go
index 2e6682b..1589fc2 100644
--- a/collector/exporter_test.go
+++ b/collector/exporter_test.go
@@ -15,6 +15,7 @@ package collector
import (
"context"
+ "os"
"testing"
"github.com/prometheus/client_golang/prometheus"
@@ -25,6 +26,15 @@ import (
const dsn = "root@/mysql"
+// testConnDSN returns the DSN to use for integration tests.
+// It uses TEST_MYSQL_DSN if set, falling back to the default Unix socket DSN.
+func testConnDSN() string {
+ if d := os.Getenv("TEST_MYSQL_DSN"); d != "" {
+ return d
+ }
+ return dsn
+}
+
func TestExporter(t *testing.T) {
if testing.Short() {
t.Skip("-short is passed, skipping test")
@@ -32,7 +42,7 @@ func TestExporter(t *testing.T) {
exporter := New(
context.Background(),
- dsn,
+ testConnDSN(),
[]Scraper{
ScrapeGlobalStatus{},
}, |
Migrate CI to GitHub Actions. * Enable dependabot for GitHub Actions. Signed-off-by: SuperQ <superq@gmail.com>
roidelapluie
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate CI to GitHub Actions.