Skip to content

Commit fe1fcfa

Browse files
committed
chore: fail the parsing if name & type invalid
1 parent d49dc61 commit fe1fcfa

File tree

1 file changed

+6
-4
lines changed

1 file changed

+6
-4
lines changed

sysfs/class_drm_amdgpu.go

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -105,6 +105,12 @@ func parseClassDRMAMDGPUCard(card string) (ClassDRMCardAMDGPUStats, error) {
105105

106106
stats := ClassDRMCardAMDGPUStats{Name: card}
107107
// Read only specific files for faster data gathering.
108+
if n, t, err := readDevInfo(card); err == nil {
109+
stats.DevName = n
110+
stats.DevType = t
111+
} else {
112+
return ClassDRMCardAMDGPUStats{}, err
113+
}
108114
if v, err := readDRMCardField(card, "gpu_busy_percent"); err == nil {
109115
stats.GPUBusyPercent = *util.NewValueParser(v).PUInt64()
110116
}
@@ -135,10 +141,6 @@ func parseClassDRMAMDGPUCard(card string) (ClassDRMCardAMDGPUStats, error) {
135141
if v, err := readDRMCardField(card, "unique_id"); err == nil {
136142
stats.UniqueID = v
137143
}
138-
if n, t, err := readDevInfo(card); err == nil {
139-
stats.DevName = n
140-
stats.DevType = t
141-
}
142144

143145
return stats, nil
144146
}

0 commit comments

Comments
 (0)