ef-themes failing to load on Emacs 31 after Commit a4b5f93

[eamonnsullivan]

I use straight.el and recently pulled and picked up that latest commit. When I restarted Emacs, it came up in the default theme (ow, my eyes). When I tried to load an ef-theme directly, the error was as follows:

Symbol’s value as variable is void: fg-heading-0

When I reverted that commit, everything worked again.

I'm on:

GNU Emacs 31.0.50 (build 2, aarch64-apple-darwin24.6.0, NS
 appkit-2575.70 Version 15.7.3 (Build 24G419)) of 2026-02-16

(Basically, emacs-plus@31 on MacOS Sequoia 15.7.4 (24G517))

Please let me know what else you need to know.

[eamonnsullivan]

No, I also can't see a thing in that commit that would cause this... Maybe it's a combination of what happened in the last couple of commits before that.

[eamonnsullivan]

The same thing happens with modus-themes, which has a very similar commit around the same time.

[protesilaos]

Hello @eamonnsullivan!

Can you try to delete the package, restart Emacs, and then install it again?

I was not expecting this to happen. But if it breaks things, I will revert the change.

[eamonnsullivan]

That was the first thing I tried: I removed the entire straight directory and let it pull again and rebuild.

[protesilaos]

Thank you! I reverted the change. Will take a closer look at what is happening there.

[eamonnsullivan]

Thank you! Sorry, I couldn't be more specific. I still don't see what could have caused an issue.

[protesilaos]

You are welcome! I suspect the problem is with the modus-themes-theme which has a check for if the theme already exists. If it does, then it skips the provide-theme part. But in this case, the theme has only been declared, but never loaded. So the provide-theme has to happen.