Skip to content

Commit bafe3ad

Browse files
Update test that relies on ES5-style classes
1 parent fb75aa6 commit bafe3ad

1 file changed

Lines changed: 10 additions & 11 deletions

File tree

spec/disposable-spec.js

Lines changed: 10 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -23,19 +23,18 @@ describe("Disposable", function() {
2323
expect(disposalAction.callCount).toBe(1)
2424
})
2525

26-
it('can be extended by ES5-style classes', () => {
27-
function MyDisposable () {
28-
// super
29-
Disposable.apply(this, arguments)
26+
it("can be extended by ES6-style classes", () => {
27+
class MyDisposable extends Disposable {
28+
constructor(...args) {
29+
super(...args);
30+
}
3031
}
3132

32-
MyDisposable.prototype = new Disposable()
33-
34-
let actionCalled = false
35-
const disposable = new MyDisposable(() => { actionCalled = true })
36-
disposable.dispose()
37-
expect(actionCalled).toBe(true)
38-
})
33+
let actionCalled = false;
34+
const disposable = new MyDisposable(() => { actionCalled = true });
35+
disposable.dispose();
36+
expect(actionCalled).toBe(true);
37+
});
3938

4039
describe(".isDisposable(object)", () => {
4140
it("true if the object implements the ::dispose function", function() {

0 commit comments

Comments
 (0)