You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
fix: resolve header staging regression from Issue #38 fix
URGENT FIX: Restore same-component header includes while preserving cross-package functionality
Problem:
- Previous Issue #38 fix broke same-component headers like #include "simd_utils.h"
- CI dropped from 276/280 targets to 270/280 targets
- Components like image_processing:simd_utils failed to find their own headers
Root Cause:
- Directory structure preservation logic was applied to ALL headers
- Same-component headers need basename staging (e.g., "simd_utils.h" → "simd_utils.h")
- Cross-package headers need directory preservation (e.g., "foundation/types.h" → "foundation/types.h")
Solution:
- Implemented hybrid approach with pattern detection:
1. Cross-package headers (path contains "test/" or "/foundation/") → preserve directory structure
2. Same-component headers (normal case) → use basename for local includes
Testing:
- ✅ simd_utils builds successfully with "simd_utils.h" include
- ✅ calculator_c_component builds successfully
- ✅ http_service_component builds successfully
- ✅ cross_package_headers:consumer_component still works with "foundation/types.h"
Impact:
- Restores CI success rate while maintaining Issue #38 cross-package fix
- Both local and cross-package header patterns work correctly
0 commit comments